Conversation
Signed-off-by: Grégoire Payen de La Garanderie <gregoire.payen.de.la.garanderie@intel.com>
Signed-off-by: Grégoire Payen de La Garanderie <gregoire.payen.de.la.garanderie@intel.com>
AlbertvanHouten
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how optional dependencies are managed in the project, moving many previously core requirements to extras and updating import patterns to avoid unnecessary dependencies. These changes make the installation process more flexible and reduce the risk of installing unused packages, especially for CLI, tabular, visualization, and file format support. Imports for optional packages are now performed only when needed, and the test configuration is updated to reflect the new extras.
Dependency management improvements:
h5py,matplotlib,nibabel,scipy,requests,tokenizers,protobuf,tabulate,nltk,portalocker,tensorboardX) fromrequirements-core.txtto optional extras insetup.py, reducing the default dependency footprint. [1] [2] [3]setup.pyto define new extras for various features (e.g.,cli,visualizer,h5py,nibabel,protobuf,tabulate,nlp,scipy) and grouped dependencies by functionality.Codebase import refactoring:
tabulate,nltk.corpus.stopwords, andDistanceCompareVisualizer) to be performed only at the point of use, preventing import errors when extras are not installed. [1] [2] [3] [4] [5] [6]Testing configuration updates:
tox.inito install the new extras for relevant test environments, ensuring tests run with the appropriate optional dependencies.Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.