Rename bbox_labels and polyon_labels to labels#1881
Merged
Conversation
Signed-off-by: Grégoire Payen de La Garanderie <gregoire.payen.de.la.garanderie@intel.com>
AlbertvanHouten
approved these changes
Sep 17, 2025
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Grégoire Payen de La Garanderie <gregoire.payen.de.la.garanderie@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some datasets like COCO have multiple shapes like bounding box and polygon for the same annotation. Those annotation shapes share the same labels but since the legacy Datumaro dataset does not support sharing the labels, they are duplicated.
When converting to the new dataset format, we do not want to create separate fields for the bounding box and polygon labels because they are the same and trying to create multiple fields of the same type result in a conflict. Therefore, we use the same name both the bounding box and polygon labels. This means that the bounding and polygon converters will overwrite each others labels but this is not a problem since the values are the same. In the future, it would be better to add validation for that.
Checklist