Conversation
added 3 commits
November 8, 2021 15:38
IRDonch
suggested changes
Nov 8, 2021
IRDonch
reviewed
Nov 9, 2021
IRDonch
approved these changes
Nov 10, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves
ImageandByteImageclasses tocomponents.media, because these classes are parts of the domain model.uitlsare more about auxiliary things, which can be replaced by other providers.ImageandByteImageare moved fromdatumaro.util.imagetodatumaro.components.mediaImage.__init__'sloaderparameter merged intodata, because it was not used and their semantics was overlapping.It seems that
loadercan be more clear, though.cacheparameter, because it was not used.Imagector's parameters are now mostly kw-onlyHow to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.