Conversation
84b16c6 to
ff4cd80
Compare
ff4cd80 to
dc85888
Compare
zhiltsov-max
left a comment
There was a problem hiding this comment.
Please check the updated class descriptions for correctness.
Future updates could include:
- ignoring attributes in classification split (for captions, descriptions and other technical attributes)
- splitting using an attribute as label in classification split
- using polygons and masks in detection split
| Produces a split with a specified ratio of images, avoiding having same | ||
| labels in different subsets.|n |
There was a problem hiding this comment.
Here, we avoid having the same person id or object id. It could be label or attribute if attr_for_id is specified.
There was a problem hiding this comment.
One more thing is, actually train and val set share person id or object id. (Most person re-identification data doesn't have val set though). But they do not share IDs with test set.
I'm not sure how accurate the explanation should be.
If you feel the current explanation is sufficient, please leave it as it is.
Thank you for revising the descriptions.
|
Optional, enabled by default.
I mean using a single attribute, like in re-id. Maybe, using some subset of them / ignoring some attributes.
In Mask R-CNN they are intermixed with segmentation task. I, personally, consider these types of annotations more or less interchangeable, because all these types can be used for training a segmentation and a detection algorithm. |
…SpecificSplit), 3. revise test code
* syncing util/mask_tools.py * syncing util/image.py * keeping exif unconditionally * syncing components/media.py * syncing components/importer.py * syncing util/meta_file_util.py * moving cli/contexts/project/diff.py to cli/util/compare.py * moving Registry and PluginRegistry to components/registry.py * syncing components/exporter.py * syncing components/hl_ops.py * syncing components/dataset.py * limiting opencv version (due to opencv/opencv#25809) * fixes * upper case extension fix * fixes * always keeping exif info * limiting opencv version * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * test for reading exif orientation * changelog entry * fixed isort * fixed test * fixed changelog * Update src/datumaro/components/hl_ops/__init__.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * fixing filter examples * hl_ops tests * syncing plugins/data_formats/celeba * syncing plugins/data_formats/cifar.py * setting DETECT_CONFIDENCE for yolo formats * syncing plugins/data_formats/image_dir.py * better detection for yolo classification importer * syncing plugins/data_formats/imagenet.py and plugins/data_formats/imagenet_txt.py * syncing plugins/data_formats/camvid.py * syncing tests/integration/cli/test_detect_format.py * syncing cli/util/project.py * syncing tests/integration/cli/test_filter.py * syncing tests/integration/cli/test_transform.py * yolo streaming exporter * syncing plugins/data_formats/coco * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update src/datumaro/components/media.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update tests/unit/test_video.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * Update src/datumaro/components/registry.py Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * coco find_images_dir do not fail if images folder doe not exist - because cvat needs to be able to export and then import dataset without images * coco find_rootpath do not fail if path does not end with ANNOTATIONS_DIR - because cvat needs it * fixes * fix linters * tests for HLOps.compare * syncing tests/unit/test_image.py * accounting for the new flag in cv2 * syncing components/importer.py * fixes * fixes * fixes * fixes * tests in test_masks.py from upstream * a bit of info on ImageColorChannel.UNCHANGED * fixing wrong merge * removing bad changes * rolling back changes in test * do not recollect subset names in StreamDatasetStorage if transformations do not change subsets * fixes * Refactor with_subset_dirs * Support detect() calls with no return value * Update importer detection confidence * Lower the default confidence * Align default format detection confidence in detector and importer * Clean imports * syncing tests/conftest.py and tests/unit/data_formats/conftest.py * syncing imagenet tests * test new yolo classification detetection behaviour * syncing tests/unit/test_format_detection.py * Apply suggestions from code review Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * fixes * fixes * Apply suggestions from code review Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com> * small fixes * basic streaming tests for coco and yolo formats * returning previous tests and behaviour for coco * Improve function name * raising error on unknown image id * test coco streaming * test yolo streaming --------- Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
Summary
This PR includes
How to test
Unittest
Testing classification split with imagenet dataset.
Testing detection split with voc dataset
Testing re-identification split with imagenet dataset.
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.