Upload data explorer model in public storage by sooahleex · Pull Request #813 · open-edge-platform/datumaro

sooahleex · 2023-02-17T08:47:54Z

Summary

Update data explorer models (bin, xml files) that uploaded in the openvinotoolkit storage.
Enable unit tests for data explorer.

Related to 103458, 104094, 101229

How to test

Checklist

I submit my changes into the develop branch
I have added description of my changes into CHANGELOG
I have updated the documentation accordingly
I have added tests to cover my changes
I have linked related issues

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

codecov-commenter · 2023-02-17T09:16:44Z

Codecov Report

Base: 77.73% // Head: 78.26% // Increases project coverage by +0.52% 🎉

Coverage data is based on head (6351c60) compared to base (6812481).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #813      +/-   ##
===========================================
+ Coverage    77.73%   78.26%   +0.52%     
===========================================
  Files          184      184              
  Lines        23570    23563       -7     
  Branches      5082     4880     -202     
===========================================
+ Hits         18323    18442     +119     
+ Misses        4168     4028     -140     
- Partials      1079     1093      +14

Flag	Coverage Δ
macos-11_Python-3.10	`?`
macos-11_Python-3.7	`?`
macos-11_Python-3.8	`77.59% <0.00%> (-0.01%)`	⬇️
macos-11_Python-3.9	`?`
ubuntu-20.04_Python-3.10	`?`
ubuntu-20.04_Python-3.7	`?`
ubuntu-20.04_Python-3.8	`78.24% <100.00%> (+0.64%)`	⬆️
ubuntu-20.04_Python-3.9	`?`
windows-2019_Python-3.10	`?`
windows-2019_Python-3.7	`?`
windows-2019_Python-3.8	`78.18% <100.00%> (+0.64%)`	⬆️
windows-2019_Python-3.9	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
datumaro/plugins/searcher.py	`91.66% <100.00%> (+71.48%)`	⬆️
datumaro/util/os_util.py	`63.35% <0.00%> (-8.62%)`	⬇️
datumaro/plugins/data_formats/kitti_raw/base.py	`84.44% <0.00%> (-1.67%)`	⬇️
datumaro/plugins/ndr.py	`75.00% <0.00%> (-1.09%)`	⬇️
datumaro/plugins/data_formats/coco/base.py	`91.30% <0.00%> (-0.67%)`	⬇️
datumaro/plugins/data_formats/yolo/base.py	`89.82% <0.00%> (-0.60%)`	⬇️
datumaro/util/test_utils.py	`84.12% <0.00%> (-0.53%)`	⬇️
datumaro/plugins/data_formats/icdar/base.py	`87.15% <0.00%> (-0.46%)`	⬇️
datumaro/plugins/data_formats/coco/exporter.py	`85.74% <0.00%> (-0.43%)`	⬇️
datumaro/plugins/data_formats/voc/exporter.py	`82.60% <0.00%> (-0.39%)`	⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

vinnamkim

LGTM.

vinnamkim

LGTM.

* Add daily/weekly test triggers (#811) * Add daily/weekly checks in schedule * Update for testing * Fix version * Fix version * Fix version * Update ttest configuration * Rename daily to nightly * Apply some feedbacks * Apply some feedbacks * Correct wrong file path. * Raise ImportError on importing malformed COCO directory (#812) * Raise ImportError on importing malformed COCO directory - Previously, COCOImporter implicitly set its rootpath and images_dir unless the directory structure is not well formed. This makes users cannot know what's happening although their dataset structure is malformed. As a result, after importing, users try to load its images but fail and don't know why. Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Update CHANGELOG.md Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix isort Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix unittest Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix testcase Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix testcase Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Image should have 2 or 3 dims Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix testcase Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Upload data explorer model in public storage (#813) * Upload model in public storage * Update model_dir * Make dir * Skip test if macos * Skip unit tests if macos --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> Co-authored-by: Emily Chun <emily.chun@intel.com> Co-authored-by: Sooah Lee <sooah.lee@intel.com>

* Update version to release v1.0 early version to PyPI * Dev to 1.0.0 pre-release (#817) * Add daily/weekly test triggers (#811) * Add daily/weekly checks in schedule * Update for testing * Fix version * Fix version * Fix version * Update ttest configuration * Rename daily to nightly * Apply some feedbacks * Apply some feedbacks * Correct wrong file path. * Raise ImportError on importing malformed COCO directory (#812) * Raise ImportError on importing malformed COCO directory - Previously, COCOImporter implicitly set its rootpath and images_dir unless the directory structure is not well formed. This makes users cannot know what's happening although their dataset structure is malformed. As a result, after importing, users try to load its images but fail and don't know why. Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Update CHANGELOG.md Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix isort Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix unittest Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix testcase Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix testcase Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Image should have 2 or 3 dims Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix testcase Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Upload data explorer model in public storage (#813) * Upload model in public storage * Update model_dir * Make dir * Skip test if macos * Skip unit tests if macos --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> Co-authored-by: Emily Chun <emily.chun@intel.com> Co-authored-by: Sooah Lee <sooah.lee@intel.com> --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> Co-authored-by: chuneuny <emily.chun@intel.com> Co-authored-by: Sooah Lee <sooah.lee@intel.com>

* Update version to release v1.0 early version to PyPI * Dev to 1.0.0 pre-release (#817) * Add daily/weekly test triggers (#811) * Add daily/weekly checks in schedule * Update for testing * Fix version * Fix version * Fix version * Update ttest configuration * Rename daily to nightly * Apply some feedbacks * Apply some feedbacks * Correct wrong file path. * Raise ImportError on importing malformed COCO directory (#812) * Raise ImportError on importing malformed COCO directory - Previously, COCOImporter implicitly set its rootpath and images_dir unless the directory structure is not well formed. This makes users cannot know what's happening although their dataset structure is malformed. As a result, after importing, users try to load its images but fail and don't know why. Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Update CHANGELOG.md Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix isort Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix unittest Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix testcase Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix testcase Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Image should have 2 or 3 dims Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Fix testcase Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Upload data explorer model in public storage (#813) * Upload model in public storage * Update model_dir * Make dir * Skip test if macos * Skip unit tests if macos --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> Co-authored-by: Emily Chun <emily.chun@intel.com> Co-authored-by: Sooah Lee <sooah.lee@intel.com> * [Release] Fix/update 3rd party txt (#820) * Update 3rd-party.txt Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Convert tab to spaces Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> * Remove the duplicated contexts * Enable doc build on release branch * Update changelog * Apply code review feedbacks * Remove a blank line * Update version.py * Update CHANGELOG.md * Update CHANGELOG.md * Add some description (#832) --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> Co-authored-by: chuneuny <emily.chun@intel.com> Co-authored-by: Sooah Lee <sooah.lee@intel.com>

sooahleex requested review from bonhunko, vinnamkim and wonjuleee February 17, 2023 08:55

vinnamkim previously approved these changes Feb 17, 2023

View reviewed changes

sooahleex dismissed vinnamkim’s stale review via 8852424 February 17, 2023 09:26

sooahleex added 3 commits February 18, 2023 01:44

Upload model in public storage

e47a287

Update model_dir

39f5fbc

Make dir

8852424

vinnamkim approved these changes Feb 20, 2023

View reviewed changes

sooahleex added this pull request to the merge queue Feb 20, 2023

Merged via the queue into open-edge-platform:develop with commit c6c55e5 Feb 20, 2023

vinnamkim added this to the 1.0.0 milestone Feb 20, 2023

sooahleex added 2 commits February 20, 2023 18:40

Skip test if macos

79dac69

Skip unit tests if macos

6351c60

sooahleex mentioned this pull request Feb 21, 2023

Upload data explorer model in public storage for v1.0.0 pre release #819

Closed

7 tasks

sooahleex mentioned this pull request Feb 24, 2023

Add data explorer feature #773

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upload data explorer model in public storage#813

Upload data explorer model in public storage#813
sooahleex merged 5 commits into
open-edge-platform:developfrom
sooahleex:data_explorer_model

sooahleex commented Feb 17, 2023

Uh oh!

codecov-commenter commented Feb 17, 2023 •

edited

Loading

Uh oh!

vinnamkim left a comment

Uh oh!

vinnamkim left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sooahleex commented Feb 17, 2023

Summary

How to test

Checklist

License

Uh oh!

codecov-commenter commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vinnamkim left a comment

Choose a reason for hiding this comment

Uh oh!

vinnamkim left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Feb 17, 2023 •

edited

Loading