Add prefix to secret key#878
Merged
vinnamkim merged 1 commit intoMar 22, 2023
Merged
Conversation
- Remove redundant file also Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## releases/1.1.0 #878 +/- ##
==================================================
+ Coverage 78.49% 78.55% +0.05%
==================================================
Files 206 205 -1
Lines 24939 24943 +4
Branches 5007 5009 +2
==================================================
+ Hits 19577 19595 +18
+ Misses 4236 4222 -14
Partials 1126 1126
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
chuneuny-emily
approved these changes
Mar 22, 2023
wonjuleee
reviewed
Mar 22, 2023
wonjuleee
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
argparseexpects one argument for--encryption-key.-andargparserecognizes it as a new argument directive.datum-prefix to the secret key.How to test
The existing tests cover this change.
Checklist
License
Feel free to contact the maintainers if that's a concern.