Refactor Images by cih9088 · Pull Request #921 · open-edge-platform/datumaro

cih9088 · 2023-04-07T04:36:44Z

Summary

Refactoring Media (CVS-107626).

A following work of #911.

Refactored Image, RoIImage, MosaicImage
Deprecated ByteImage
Fixed PointCloud design mismatch
Added extra images save functionality in PointCloud
Removed related_images directory for Datumaro/Datumaro binary format and used images directory for extra images instead.
Fixed to compare contents in tests.utils.test_utils.compare_datasets_3d

We may require to split the medi.py into multiple files.

How to test

Checklist

I have added unit tests to cover my changes.
I have added integration tests to cover my changes.
I have added the description of my changes into CHANGELOG.
I have updated the documentation accordingly

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
I have updated the license header for each file (see an example below).

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

codecov-commenter · 2023-04-07T05:00:46Z

Codecov Report

Patch coverage: 75.65% and project coverage change: -0.15 ⚠️

Comparison is base (d122ab8) 78.88% compared to head (a64b42f) 78.73%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #921      +/-   ##
===========================================
- Coverage    78.88%   78.73%   -0.15%     
===========================================
  Files          215      215              
  Lines        25220    25478     +258     
  Branches      5046     5085      +39     
===========================================
+ Hits         19895    20061     +166     
- Misses        4191     4255      +64     
- Partials      1134     1162      +28

Flag	Coverage Δ
macos-11_Python-3.8	`77.73% <75.65%> (-0.15%)`	⬇️
ubuntu-20.04_Python-3.8	`78.73% <75.65%> (-0.15%)`	⬇️
windows-2019_Python-3.8	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
datumaro/components/dataset_base.py	`72.89% <0.00%> (-1.80%)`	⬇️
datumaro/components/filter.py	`91.34% <0.00%> (-0.93%)`	⬇️
datumaro/plugins/data_formats/ade20k2017.py	`83.00% <ø> (ø)`
datumaro/plugins/data_formats/ade20k2020.py	`85.24% <ø> (ø)`
datumaro/plugins/data_formats/ava/ava.py	`84.00% <ø> (ø)`
datumaro/plugins/data_formats/camvid.py	`87.14% <ø> (ø)`
datumaro/plugins/data_formats/coco/base.py	`92.09% <ø> (ø)`
datumaro/plugins/data_formats/datumaro/format.py	`100.00% <ø> (ø)`
...aro/plugins/data_formats/datumaro_binary/format.py	`89.47% <ø> (-0.53%)`	⬇️
datumaro/plugins/data_formats/imagenet_txt.py	`86.56% <ø> (ø)`
... and 49 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

vinnamkim

LGTM.

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

bonhunko

LGTM

cih9088 added 16 commits April 7, 2023 12:32

test: refactor media

8103162

refactor: image

86b22f1

fix: compare contents

4c4559d

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

refactor: split fromdata

b76fa17

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

refactor: rename

c8ef526

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

feat: add from_self

1799a5b

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

refactor: make it more general

7ff6c81

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

fix: ext

3486b89

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

test: add image test

3ff96ae

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

fix: from_self

77fe464

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

test: add a bit more

13d408e

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

fix: add barrier

4c958c6

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

fix: rebase issue

a650d92

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

chore: add to changelog

e3937e6

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

style: black

f3d58ff

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

fix: window path

ab9e005

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

cih9088 added the refactoring label Apr 7, 2023

cih9088 added this to the 1.2.0 milestone Apr 7, 2023

cih9088 requested a review from vinnamkim April 7, 2023 04:36

cih9088 requested review from a team as code owners April 7, 2023 04:36

cih9088 requested review from JihwanEom, bonhunko, chuneuny-emily and wonjuleee April 7, 2023 04:36

cih9088 force-pushed the refactor/image branch 2 times, most recently from b75c5b0 to e3937e6 Compare April 7, 2023 04:39

cih9088 mentioned this pull request Apr 7, 2023

Fix not saving extra images of PointCloud in datumaro format #918

Merged

6 tasks

fix: compare data directly

6d27bc9

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

cih9088 force-pushed the refactor/image branch from cbd0014 to 6d27bc9 Compare April 7, 2023 06:13

cih9088 marked this pull request as draft April 7, 2023 06:42

cih9088 marked this pull request as ready for review April 7, 2023 07:36

fix: remove related_images dir

e933e90

cih9088 force-pushed the refactor/image branch from 00a6624 to e933e90 Compare April 7, 2023 09:06

fix: typo

3fba27f

vinnamkim reviewed Apr 10, 2023

View reviewed changes

cih9088 added 2 commits April 10, 2023 13:21

fix: remove from_data

ef3b3b8

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

feat: raise an error with description

08ce590

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

cih9088 force-pushed the refactor/image branch from bb19f1d to ef3b3b8 Compare April 10, 2023 05:16

vinnamkim reviewed Apr 10, 2023

View reviewed changes

Comment thread datumaro/components/media.py Outdated

vinnamkim previously approved these changes Apr 10, 2023

View reviewed changes

cih9088 added 2 commits April 11, 2023 09:46

docs: typo

e19ad25

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

refactor: compact

18d8a40

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

JihwanEom reviewed Apr 11, 2023

View reviewed changes

Comment thread datumaro/components/filter.py Outdated

Comment thread datumaro/components/media.py Outdated

cih9088 added 3 commits April 11, 2023 10:33

docs: a bit more explicit changelog

6e430dc

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

fix: consider bytes as well when initializing

bd13ebf

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

fix: use filename if exists

a64b42f

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

cih9088 dismissed vinnamkim’s stale review via 18d8a40 April 11, 2023 01:45

wonjuleee reviewed Apr 11, 2023

View reviewed changes

cih9088 force-pushed the refactor/image branch from 3aa8cf1 to a64b42f Compare April 11, 2023 03:01

wonjuleee approved these changes Apr 11, 2023

View reviewed changes

JihwanEom approved these changes Apr 11, 2023

View reviewed changes

vinnamkim approved these changes Apr 11, 2023

View reviewed changes

bonhunko approved these changes Apr 11, 2023

View reviewed changes

cih9088 merged commit bddf3cb into open-edge-platform:develop Apr 11, 2023

cih9088 mentioned this pull request Apr 17, 2023

Refactor Image/PointCloud 2 #944

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Images#921

Refactor Images#921
cih9088 merged 26 commits intoopen-edge-platform:developfrom
cih9088:refactor/image

cih9088 commented Apr 7, 2023 •

edited

Loading

Uh oh!

codecov-commenter commented Apr 7, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vinnamkim left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bonhunko left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

cih9088 commented Apr 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test

Checklist

License

Uh oh!

codecov-commenter commented Apr 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vinnamkim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bonhunko left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cih9088 commented Apr 7, 2023 •

edited

Loading

codecov-commenter commented Apr 7, 2023 •

edited

Loading