Skip to content

Add unit test for ArrowDataset#934

Merged
cih9088 merged 3 commits into
open-edge-platform:releases/1.2.0from
cih9088:test/arrow
Apr 17, 2023
Merged

Add unit test for ArrowDataset#934
cih9088 merged 3 commits into
open-edge-platform:releases/1.2.0from
cih9088:test/arrow

Conversation

@cih9088
Copy link
Copy Markdown
Contributor

@cih9088 cih9088 commented Apr 14, 2023

Summary

A following work of #931

  • Added unit test for ArrowDataset.__getitem__.
  • Fixed typo.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

cih9088 added 3 commits April 14, 2023 16:40
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 added the tests Any changes in tests label Apr 14, 2023
@cih9088 cih9088 added this to the 1.2.0 milestone Apr 14, 2023
@cih9088 cih9088 requested review from a team as code owners April 14, 2023 08:44
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (eaae1e1) 78.65% compared to head (eeb8d8e) 78.73%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #934      +/-   ##
==================================================
+ Coverage           78.65%   78.73%   +0.08%     
==================================================
  Files                 228      228              
  Lines               26342    26344       +2     
  Branches             5249     5250       +1     
==================================================
+ Hits                20718    20742      +24     
+ Misses               4406     4385      -21     
+ Partials             1218     1217       -1     
Flag Coverage Δ
macos-11_Python-3.8 77.75% <100.00%> (+0.08%) ⬆️
ubuntu-20.04_Python-3.8 78.71% <100.00%> (+0.08%) ⬆️
windows-2019_Python-3.8 78.61% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/progress_reporting.py 61.53% <ø> (ø)
...tumaro/plugins/data_formats/arrow/arrow_dataset.py 81.61% <100.00%> (+16.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cih9088 cih9088 changed the base branch from develop to releases/1.2.0 April 14, 2023 10:19
Copy link
Copy Markdown
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cih9088 cih9088 merged commit 84b2a8a into open-edge-platform:releases/1.2.0 Apr 17, 2023
@cih9088 cih9088 deleted the test/arrow branch April 17, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Any changes in tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants