Conversation
garyloug
force-pushed
the
go_1_25_5
branch
8 times, most recently
from
71fab81 to
5afb8e9
Compare
garyloug
requested review from
Ram-srini,
SushilLakra,
cjnolan,
damiankopyto,
guptagunjan,
hyunsun,
johnoloughlin,
krishnajs,
palade,
rranjan3,
scottmbaker,
shankarsrinivas1,
soniabha-intc and
sys-orch-approve
as code owners
cjnolan
approved these changes
Jan 20, 2026
Upgrade EMF to Go 1.25.5 and bump orch-utils chart versions to also use 1.25.5 Upgraded Go version required upgraded golangci-lint. GCI, exportloopref and stylecheck linters are not available in golangci-lint 2.8.0. Removed from list of disabled linters.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade EMF to Go 1.25.5 and bump orch-utils chart versions to also use 1.25.5
Upgraded Go version required upgraded golangci-lint. GCI, exportloopref
and stylecheck linters are not available in golangci-lint 2.8.0. Removed
from list of disabled linters.
The upgraded linter flagged a lot of new errors in the existing code. Mostly unhandled errors, but also some deprecated functions and some issues with code structure. The unhandled errors were mostly from deferred calls. For test files I ignored these with nolint comments and in the actual code I logged or otherwise handled them.
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: