Skip to content

Fix saliency map issues#1232

Merged
chuneuny-emily merged 6 commits intoreleases/v0.3.0-sc1.2from
eugene/CVS-90192-fix-saliency-map
Sep 1, 2022
Merged

Fix saliency map issues#1232
chuneuny-emily merged 6 commits intoreleases/v0.3.0-sc1.2from
eugene/CVS-90192-fix-saliency-map

Conversation

@eugene123tw
Copy link
Copy Markdown
Contributor

@eugene123tw eugene123tw commented Aug 26, 2022

@eugene123tw eugene123tw requested a review from a team as a code owner August 26, 2022 15:27
@eugene123tw
Copy link
Copy Markdown
Contributor Author

run ote-test

@github-actions github-actions bot added API Any changes in OTX API ALGO Any changes in OTX Algo Tasks implementation labels Aug 26, 2022
harimkang
harimkang previously approved these changes Aug 29, 2022
Copy link
Copy Markdown
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an issue that didn't work because the type and name of ResultMediaEntity were changed?

Copy link
Copy Markdown
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'll look at the submodules first, and I'll approve it again after the commit of the submodules are merged and changed.

@eugene123tw eugene123tw requested a review from harimkang August 31, 2022 07:39
harimkang
harimkang previously approved these changes Aug 31, 2022
Copy link
Copy Markdown
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that there is still a conflict on the submodule side.

harimkang
harimkang previously approved these changes Aug 31, 2022
Copy link
Copy Markdown

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chuneuny-emily chuneuny-emily merged commit 86e9e4a into releases/v0.3.0-sc1.2 Sep 1, 2022
@chuneuny-emily chuneuny-emily deleted the eugene/CVS-90192-fix-saliency-map branch September 1, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants