Skip to content

Feature/multi batch validation#1302

Closed
sungmanc wants to merge 51 commits intodevelopfrom
feature/multi-batch-validation
Closed

Feature/multi batch validation#1302
sungmanc wants to merge 51 commits intodevelopfrom
feature/multi-batch-validation

Conversation

@sungmanc
Copy link
Copy Markdown
Contributor

@sungmanc sungmanc commented Oct 19, 2022

  • Set the default num_workers as 2 for classification / detection tasks
  • Update MPA submodule to enable multi-batch validation

sungmanc and others added 18 commits October 13, 2022 15:50
@sungmanc
modified train files for saving log files
210d69f
@sungmanc
remove useless files
b85120b
@sungmanc
update val-batch in detection training and num_workers for detection …
4e84e17 
…and classification
@sungmanc
Merge branch 'feature/multi-batch-validation' of https://github.com/o…
8c772de 
…penvinotoolkit/training_extensions into feature/multi-batch-validation
@sungmanc
remove useless files & lines
3d4b067
@sungmanc
change submodules
39ed4ca
@sungmanc
minor update
6876fb4
@sungmanc
Merge branch 'feature/multi-batch-validation' of https://github.com/o…
f1f80fd 
…penvinotoolkit/training_extensions into feature/multi-batch-validation
@sungmanc
update mpa submodule: multi-batch
30522e1
@sungmanc
update mpa submodule: reflect merge status
afefa92
@eugene123tw
fix bug
c8ee8fd
@eugene123tw
fix bug
c0bb70f
@sungmanc
minor update
2a36016
@sungmanc
update val-batch in detection training and num_workers for detection …
4697c8d 
…and classification
@sungmanc
modified train files for saving log files
b80393b
@sungmanc
remove useless files
7249e6a
@sungmanc
remove useless files & lines
9d08eb6
@sungmanc
fixed conflicts
bf52283
@sungmanc sungmanc requested a review from a team as a code owner October 19, 2022 01:33
@github-actions github-actions Bot added the ALGO Any changes in OTX Algo Tasks implementation label Oct 19, 2022
@sungmanc
Copy link
Copy Markdown
Contributor Author

sungmanc commented Oct 19, 2022

run ote-test

@harimkang
Copy link
Copy Markdown
Contributor

harimkang commented Oct 21, 2022

@harimkang , Was the develop branch latest? I just checked with the latest develop branch before 5 minutes, I still got 15 errors related to Custom_Counting_Instance_Segmentation as below.

...! I did it on develop, which I pulled this morning. I'll check it one more time.

@sungmanc
Copy link
Copy Markdown
Contributor Author

sungmanc commented Oct 21, 2022

@harimkang , Was the develop branch latest? I just checked with the latest develop branch before 5 minutes, I still got 15 errors related to Custom_Counting_Instance_Segmentation as below.

...! I did it on develop, which I pulled this morning. I'll check it one more time.

Thx a lot. please let me know if there is no problem on your side

@eugene123tw
Copy link
Copy Markdown
Contributor

eugene123tw commented Oct 21, 2022

@sungmanc Could you merge the upstream develop, external/mmdetection/detection_tasks/apis/detection/configuration.py and external/model-preparation-algorithm/mpa_tasks/apis/detection/task.py were both merged in develop

@eugene123tw
Copy link
Copy Markdown
Contributor

eugene123tw commented Oct 21, 2022

@harimkang I've checked with local OTE tests and found that there is no fail cases about num_workers and reflected MPA repo's latest change related to multi-batch for instance segmentation (@eugene123tw).

Cool! In summary, the validation batch size is flexible for detection, and instance-segmentation is currently fixed at 1, right?

@harimkang yes, this should be fixed in instance seg for the time being as there's a bug. I have added a stopgap: #1305. AFAIK, Sungman will look into it

sungmanc added 20 commits October 26, 2022 10:00
@sungmanc
minor update
5b7f43c
@sungmanc
update val-batch in detection training and num_workers for detection …
f8ae248 
…and classification
@sungmanc
modified train files for saving log files
5354b09
@sungmanc
remove useless files
002c7ee
@sungmanc
remove useless files & lines
549bba9
@sungmanc
update val-batch in detection training and num_workers for detection …
05410de 
…and classification
@sungmanc
modified train files for saving log files
91f263f
@sungmanc
remove useless files
9f096e3
@sungmanc
remove useless files & lines
0a0f578
@sungmanc
change submodules
8b33e14
@sungmanc
update latest PRs
baf9825
@sungmanc
modified train files for saving log files
bde96eb
@sungmanc
remove useless files
736e62c
@sungmanc
remove useless files & lines
e176f6b
@sungmanc
minor update
63b0bc2
@sungmanc
modified train files for saving log files
dbee757
@sungmanc
remove useless files
0c5d22c
@sungmanc
remove useless files & lines
f334021
@sungmanc
update submodule
d2368bd
@sungmanc
Merge branch 'feature/multi-batch-validation' of https://github.com/o…
9e05533 
…penvinotoolkit/training_extensions into feature/multi-batch-validation
@harimkang
Copy link
Copy Markdown
Contributor

harimkang commented Oct 26, 2022

run ote-test

@sungmanc sungmanc mentioned this pull request Oct 26, 2022
Merged
@harimkang
Copy link
Copy Markdown
Contributor

harimkang commented Oct 27, 2022

This will be addressed with the same content in PR.

@sungmanc I think it can be closed, what do you think?

@sungmanc
Copy link
Copy Markdown
Contributor Author

sungmanc commented Oct 27, 2022

This will be addressed with the same content in PR.

@sungmanc I think it can be closed, what do you think?

Sure ! Let's close this PR

@sungmanc sungmanc closed this Oct 27, 2022
@yunchu yunchu deleted the feature/multi-batch-validation branch May 3, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ALGO Any changes in OTX Algo Tasks implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sungmanc @harimkang @eugene123tw