[OTX/Semi-SL-Det] Enable training and evaluation for unbiased teacher structure#1398
Merged
jaegukhyun merged 23 commits intofeature/otxfrom Dec 23, 2022
Merged
[OTX/Semi-SL-Det] Enable training and evaluation for unbiased teacher structure#1398jaegukhyun merged 23 commits intofeature/otxfrom
jaegukhyun merged 23 commits intofeature/otxfrom
Conversation
supersoob
reviewed
Dec 5, 2022
jaegukhyun
requested review from
JihwanEom,
eugene123tw,
harimkang,
kprokofi,
sovrasov,
sungmanc and
supersoob
harimkang
reviewed
Dec 7, 2022
supersoob
reviewed
Dec 8, 2022
supersoob
reviewed
Dec 8, 2022
supersoob
reviewed
Dec 8, 2022
supersoob
reviewed
Dec 8, 2022
Contributor
Author
|
There are two major changes
|
jaegukhyun
requested review from
JihwanEom and
harimkang
and removed request for
eugene123tw,
kprokofi,
sovrasov,
sungmanc and
supersoob
harimkang
suggested changes
Dec 16, 2022
Contributor
harimkang
left a comment
harimkang
left a comment
There was a problem hiding this comment.
It looks good. I left some concerned comments.
otx/algorithms/detection/configs/detection/mobilenetv2_ssd/semisl/data_pipeline.py
Outdated
Show resolved
Hide resolved
harimkang
previously approved these changes
Dec 16, 2022
Contributor
harimkang
left a comment
harimkang
left a comment
There was a problem hiding this comment.
LGTM. Let's wait for the CI to be fixed and check the tests.
sungmanc
reviewed
Dec 16, 2022
Contributor
sungmanc
left a comment
sungmanc
left a comment
There was a problem hiding this comment.
I left some comments please check it
supersoob
previously approved these changes
Dec 19, 2022
supersoob
left a comment
supersoob
left a comment
There was a problem hiding this comment.
LGTM, thanks for the hard work. I left one command, but just suggestion.
supersoob
previously approved these changes
Dec 20, 2022
…ning_extensions into feature/otx-semisl-det
github-actions
bot
added
CLI
Contributor
Author
|
https://github.com/openvinotoolkit/training_extensions/actions/runs/3754946842/jobs/6380632103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for enabling training and evaluation for unbiased teacher structure.
'semisl' folder will be placed inside of each detection model config folder. 'semisl' folder would have template_semi.yaml, model.py, data_pipeline.py for semi-supervised learning.
Detection task determine selects its training algorithm below logic:
if template.TrainType == "SEMISUPERVISED" and 'unlabeled' in cfg.data_cfg:
train_type = "SEMISUPERVISED"
else:
train_type = "INCREMENTAL"
In addition detection task transfer its training algorithm through setting self._recipe_cfg.train_type