Add visual prompting task#2203
Conversation
639f4c5 to
043bb8a
Compare
e329a8f to
0f1fc88
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
python package |
|
visual prompting seems new task like classification or anomaly tasks. Should user install otx with |
Isn't it the default package from python? If so, I think we don't need to. |
Yes, it is already used in otx. |
Yes, it is required, but I think it would be better to implement it after implementing other tasks, export, deploy, and optimize. |
I don't think so. When I use pure python, there is no |
Yes, I agree with you. |
eunwoosh
left a comment
There was a problem hiding this comment.
Thanks for your huge effort :) I left some comments although I didn't check all the files. please take a look.
otx/algorithms/visual_prompting/adapters/pytorch_lightning/config/visual_prompting_config.py
Outdated
Show resolved
Hide resolved
otx/algorithms/visual_prompting/adapters/pytorch_lightning/config/visual_prompting_config.py
Outdated
Show resolved
Hide resolved
otx/algorithms/visual_prompting/adapters/pytorch_lightning/config/visual_prompting_config.py
Show resolved
Hide resolved
otx/algorithms/visual_prompting/adapters/pytorch_lightning/config/visual_prompting_config.py
Outdated
Show resolved
Hide resolved
otx/algorithms/visual_prompting/adapters/pytorch_lightning/datasets/dataset.py
Outdated
Show resolved
Hide resolved
otx/algorithms/visual_prompting/adapters/pytorch_lightning/datasets/dataset.py
Show resolved
Hide resolved
otx/algorithms/visual_prompting/adapters/pytorch_lightning/models/decoders/sam_mask_decoder.py
Outdated
Show resolved
Hide resolved
I'll consider it. |
jaegukhyun
left a comment
There was a problem hiding this comment.
Generally LGTM, I left a few comments.
otx/algorithms/visual_prompting/adapters/pytorch_lightning/datasets/dataset.py
Show resolved
Hide resolved
otx/algorithms/visual_prompting/configs/sam_vit_b/template.yaml
Outdated
Show resolved
Hide resolved
otx/algorithms/visual_prompting/configs/sam_vit_b/template.yaml
Outdated
Show resolved
Hide resolved
a70c521 to
84c8e16
Compare
jaegukhyun
left a comment
There was a problem hiding this comment.
LGTM, Please clean commits, when you merge this PR
Summary
This PR is to add visual prompting task (reference paper: https://arxiv.org/abs/2304.12306).
This PR includes train and eval tasks, and others (deploy, export, ...) will be proceeded in the next PRs.
TODOs
VisualPromptingDatasetAdapterDetectionDatasetAdapterhandles only images as inputs and others as annotations. It is required to create a new dataset adapter that can handle multiple inputs for visual prompting task.otx eval,with_empty_annotations()is applied and inputs of visual prompting but assigned as annotations are removed.https://github.com/openvinotoolkit/training_extensions/blob/6b045dab395274821c97fa53e3cab3d4bd3cdae3/otx/cli/tools/eval.py#L135-L138
How to test
Unit tests (local execution)
otx/algorithms/visual_prompting/utils/visual_prompting_utils.pywill be implemented if needed.Integration test (local execution)
$ tox -vv -e tests-all-py310 -- tests/integration/cli/visual_prompting ================== 6 passed, 1 warning in 3278.82s (0:54:38) ===================Checklist
License
Feel free to contact the maintainers if that's a concern.