Support encrypted dataset training#2209
Merged
goodsong81 merged 5 commits intodevelopfrom Jun 1, 2023
Merged
Conversation
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
188159e to
4be1f3c
Compare
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
ActionBaseDatasetAdapter signatures Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2209 +/- ##
========================================
Coverage 80.24% 80.25%
========================================
Files 469 469
Lines 35182 35183 +1
========================================
+ Hits 28232 28236 +4
+ Misses 6950 6947 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jaegukhyun
previously approved these changes
May 31, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
sungmanc
reviewed
May 31, 2023
Contributor
sungmanc
left a comment
There was a problem hiding this comment.
Is there no need to change the Datumaro version?
Contributor
Author
DatumaroBinary format and dataset encryption features were added months ago ( |
sungmanc
approved these changes
Jun 1, 2023
goodsong81
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
otx trainwith--encryption-keyCLI argument orENCRYPTION_KEYenv vars enables model training with an encrypted dataset.How to test
I added tests related to this change.
Checklist
License
Feel free to contact the maintainers if that's a concern.