Enable DINO to OTX - Step 1. Enable Deformable DETR to OTX#2249
Merged
jaegukhyun merged 6 commits intoopen-edge-platform:developfrom Jun 22, 2023
Merged
Enable DINO to OTX - Step 1. Enable Deformable DETR to OTX#2249jaegukhyun merged 6 commits intoopen-edge-platform:developfrom
jaegukhyun merged 6 commits intoopen-edge-platform:developfrom
Conversation
eunwoosh
reviewed
Jun 19, 2023
Contributor
eunwoosh
left a comment
There was a problem hiding this comment.
Thanks for adding great model :)
I left some comments. please take a look.
otx/algorithms/common/adapters/mmcv/ops/multi_scale_deformable_attn_pytorch.py
Outdated
Show resolved
Hide resolved
otx/algorithms/common/adapters/mmcv/ops/multi_scale_deformable_attn_pytorch.py
Outdated
Show resolved
Hide resolved
otx/algorithms/detection/adapters/mmdet/models/detectors/custom_deformable_detr_detector.py
Outdated
Show resolved
Hide resolved
otx/algorithms/detection/configs/detection/resnet50_deformable-detr/data_pipeline.py
Show resolved
Hide resolved
otx/algorithms/detection/configs/detection/resnet50_deformable-detr/template_experimental.yaml
Show resolved
Hide resolved
otx/algorithms/detection/configs/detection/resnet50_deformable-detr/template_experimental.yaml
Show resolved
Hide resolved
otx/algorithms/detection/configs/detection/resnet50_deformable-detr/template_experimental.yaml
Show resolved
Hide resolved
harimkang
reviewed
Jun 19, 2023
Contributor
harimkang
left a comment
There was a problem hiding this comment.
Welcome to the new algorithm. It looks good for the most part, and I have a few comments.
otx/algorithms/common/adapters/mmcv/ops/multi_scale_deformable_attn_pytorch.py
Show resolved
Hide resolved
otx/algorithms/detection/adapters/mmdet/models/detectors/custom_deformable_detr_detector.py
Show resolved
Hide resolved
sungmanc
reviewed
Jun 20, 2023
sungmanc
approved these changes
Jun 21, 2023
eunwoosh
approved these changes
Jun 21, 2023
harimkang
approved these changes
Jun 22, 2023
Contributor
harimkang
left a comment
There was a problem hiding this comment.
LGTM!
BTW, Anything to add to the documentation for this?
Contributor
Author
Documentation will be updated after adding DINO and conducting some experiments on public datasets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As a first step to bring DINO to OTX, this PR enable Deformable DETR to OTX.
Since mmdeploy do not support Deformable DETR(it supports only DETR), there are some custom patches for mmcv and mmdeploy ops
Known Issue
These known issues are handled after implementing DINO from this PR
How to test
Unit tests and integration tests are added. E2E Test will be added after implementing DINO
Checklist
License
Feel free to contact the maintainers if that's a concern.