Skip to content

Enable DINO to OTX - Step 1. Enable Deformable DETR to OTX#2249

Merged
jaegukhyun merged 6 commits intoopen-edge-platform:developfrom
jaegukhyun:dino
Jun 22, 2023
Merged

Enable DINO to OTX - Step 1. Enable Deformable DETR to OTX#2249
jaegukhyun merged 6 commits intoopen-edge-platform:developfrom
jaegukhyun:dino

Conversation

@jaegukhyun
Copy link
Copy Markdown
Contributor

@jaegukhyun jaegukhyun commented Jun 16, 2023

Summary

As a first step to bring DINO to OTX, this PR enable Deformable DETR to OTX.
Since mmdeploy do not support Deformable DETR(it supports only DETR), there are some custom patches for mmcv and mmdeploy ops

Known Issue

  1. Current Deformable DETR use fixed schedule, not early stopping and plateau lr decay
  2. Current Deformable DETR does not support smart weight loading, and other class incremental technique
  3. Current DetClassProbabilityMapHook does not support End-to-End detector
  4. When inference with exported Deformable DETR, there are some bottleneck for some images
    image

These known issues are handled after implementing DINO from this PR

How to test

Unit tests and integration tests are added. E2E Test will be added after implementing DINO

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests labels Jun 16, 2023
@jaegukhyun jaegukhyun marked this pull request as ready for review June 19, 2023 02:08
@jaegukhyun jaegukhyun requested a review from a team as a code owner June 19, 2023 02:08
Copy link
Copy Markdown
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding great model :)
I left some comments. please take a look.

Copy link
Copy Markdown
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the new algorithm. It looks good for the most part, and I have a few comments.

@jaegukhyun jaegukhyun added this to the 1.4.0 milestone Jun 21, 2023
@jaegukhyun jaegukhyun requested a review from harimkang June 22, 2023 00:16
Copy link
Copy Markdown
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BTW, Anything to add to the documentation for this?

@jaegukhyun
Copy link
Copy Markdown
Contributor Author

LGTM!

BTW, Anything to add to the documentation for this?

Documentation will be updated after adding DINO and conducting some experiments on public datasets

@jaegukhyun jaegukhyun merged commit cbfffbe into open-edge-platform:develop Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants