Enable DINO to OTX - Step 2. Upgrade Deformable DETR to DINO#2266
Merged
jaegukhyun merged 11 commits intoopen-edge-platform:developfrom Jun 27, 2023
Merged
Enable DINO to OTX - Step 2. Upgrade Deformable DETR to DINO#2266jaegukhyun merged 11 commits intoopen-edge-platform:developfrom
jaegukhyun merged 11 commits intoopen-edge-platform:developfrom
Conversation
1b4ef0a to
3c33ab0
Compare
eunwoosh
reviewed
Jun 27, 2023
Contributor
eunwoosh
left a comment
There was a problem hiding this comment.
Thanks for your work! I think it should be not easy work.
I left some comments please take a look.
otx/algorithms/detection/adapters/mmdet/models/detectors/custom_dino_detector.py
Outdated
Show resolved
Hide resolved
otx/algorithms/detection/adapters/mmdet/models/detectors/custom_dino_detector.py
Outdated
Show resolved
Hide resolved
otx/algorithms/detection/configs/detection/resnet50_dino/data_pipeline.py
Outdated
Show resolved
Hide resolved
otx/algorithms/detection/configs/detection/resnet50_dino/template_experimental.yaml
Show resolved
Hide resolved
sungmanc
reviewed
Jun 27, 2023
Contributor
sungmanc
left a comment
There was a problem hiding this comment.
Thanks for the great work.
otx/algorithms/detection/configs/detection/resnet50_dino/data_pipeline.py
Outdated
Show resolved
Hide resolved
eunwoosh
previously approved these changes
Jun 27, 2023
sungmanc
approved these changes
Jun 27, 2023
eunwoosh
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for upgrading Deformable DETR to DINO.
Since DINO is only able to use in mmdet3.x. Some of modules are come from mmdet3.x.
From this PR, otx can train, eval, export DINO.
Next PR will contain
How to test
Unit, Intg
** E2E tests will be added in next PR.
Checklist
License
Feel free to contact the maintainers if that's a concern.