Skip to content

Mergeback releases/1.5.0 to develop#2663

Merged
yunchu merged 5 commits intodevelopfrom
mergeback/1.5.0-to-dev
Nov 23, 2023
Merged

Mergeback releases/1.5.0 to develop#2663
yunchu merged 5 commits intodevelopfrom
mergeback/1.5.0-to-dev

Conversation

@yunchu
Copy link
Copy Markdown
Contributor

@yunchu yunchu commented Nov 21, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Songki Choi and others added 5 commits November 20, 2023 13:30
* Make max_num_detections configurable

* Fix RCNN case with integration test

* Apply max_num_detections to train_cfg, too

---------
Signed-off-by: Songki Choi <songki.choi@intel.com>
Fix bug that auto adaptive batch size raises an error if CUDA isn't available (#2410)

---------
Co-authored-by: Sungman Cho <sungman.cho@intel.com>
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests DOC Improvements or additions to documentation labels Nov 21, 2023
Copy link
Copy Markdown

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (6b8729a) 81.03% compared to head (e995639) 80.99%.

Files Patch % Lines
.../algorithms/detection/adapters/mmdet/configurer.py 18.75% 13 Missing ⚠️
...rc/otx/algorithms/detection/adapters/mmdet/task.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2663      +/-   ##
===========================================
- Coverage    81.03%   80.99%   -0.04%     
===========================================
  Files          516      516              
  Lines        38593    38624      +31     
===========================================
+ Hits         31272    31285      +13     
- Misses        7321     7339      +18     
Flag Coverage Δ
py310 80.99% <47.05%> (-0.04%) ⬇️
py38 80.97% <47.05%> (-0.04%) ⬇️
py39 80.98% <47.05%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sovrasov sovrasov mentioned this pull request Nov 21, 2023
8 tasks
@yunchu yunchu marked this pull request as ready for review November 23, 2023 01:08
@yunchu yunchu requested a review from a team as a code owner November 23, 2023 01:08
@yunchu yunchu merged commit 89d3c9d into develop Nov 23, 2023
@yunchu yunchu deleted the mergeback/1.5.0-to-dev branch November 23, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants