Skip to content

Add unit tests for XPU related code#3049

Merged
sovrasov merged 11 commits intodevelop-idevfrom
kp/add_unit_tests_dgpus
Mar 7, 2024
Merged

Add unit tests for XPU related code#3049
sovrasov merged 11 commits intodevelop-idevfrom
kp/add_unit_tests_dgpus

Conversation

@kprokofi
Copy link
Copy Markdown
Contributor

@kprokofi kprokofi commented Mar 6, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Mar 6, 2024
@kprokofi kprokofi requested review from eunwoosh and sovrasov March 6, 2024 23:31
@kprokofi kprokofi marked this pull request as ready for review March 6, 2024 23:49
@kprokofi kprokofi requested a review from a team as a code owner March 6, 2024 23:49
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (0c9b97b) to head (6a45aad).
Report is 1 commits behind head on develop-idev.

Additional details and impacted files
@@               Coverage Diff                @@
##           develop-idev    #3049      +/-   ##
================================================
+ Coverage         80.13%   80.57%   +0.44%     
================================================
  Files               533      534       +1     
  Lines             40440    40471      +31     
================================================
+ Hits              32405    32608     +203     
+ Misses             8035     7863     -172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! LGTM but, I found some skips depending on XPU and CUDA. I think unit test should be available on all environments. Could you remove skip and mock properly?

@kprokofi
Copy link
Copy Markdown
Contributor Author

kprokofi commented Mar 7, 2024

Thanks for your work! LGTM but, I found some skips depending on XPU and CUDA. I think unit test should be available on all environments. Could you remove skip and mock properly?

Some of the tests works only when XPU device because those part of the code works only with specific device. We can't run it for all devices because IPEX that required to be imported is not available for cuda.

@sovrasov sovrasov merged commit a5dcbd5 into develop-idev Mar 7, 2024
@sovrasov sovrasov deleted the kp/add_unit_tests_dgpus branch March 7, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants