Add unit tests for XPU related code#3049
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-idev #3049 +/- ##
================================================
+ Coverage 80.13% 80.57% +0.44%
================================================
Files 533 534 +1
Lines 40440 40471 +31
================================================
+ Hits 32405 32608 +203
+ Misses 8035 7863 -172 ☔ View full report in Codecov by Sentry. |
eunwoosh
left a comment
There was a problem hiding this comment.
Thanks for your work! LGTM but, I found some skips depending on XPU and CUDA. I think unit test should be available on all environments. Could you remove skip and mock properly?
Some of the tests works only when XPU device because those part of the code works only with specific device. We can't run it for all devices because IPEX that required to be imported is not available for cuda. |
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.