refactor: InMemoryProvider throwing when types mismatched#442
Merged
beeme1mr merged 1 commit intoopen-feature:mainfrom Apr 23, 2025
Merged
Conversation
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 86.47% 86.47%
=======================================
Files 42 42
Lines 1671 1671
Branches 177 177
=======================================
Hits 1445 1445
Misses 187 187
Partials 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I'm not sure this is technically a bug, it's more of an optimization. It's valid for providers to throw, it's just less performant. I'd suggest we adjust the prefix to "chore" or "refactor". |
Contributor
Author
Happy to update the title - I went with fix because #441 was labelled as a bug |
kylejuliandev
changed the title
beeme1mr
approved these changes
Apr 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
🤖 I have created a release *beep* *boop* --- ## [2.5.0](v2.4.0...v2.5.0) (2025-04-25) ### ✨ New Features * Add support for hook data. ([#387](#387)) ([4563512](4563512)) ### 🧹 Chore * add NuGet auditing ([#454](#454)) ([42ab536](42ab536)) * Change file scoped namespaces and cleanup job ([#453](#453)) ([1e74a04](1e74a04)) * **deps:** update codecov/codecov-action action to v5.4.2 ([#432](#432)) ([c692ec2](c692ec2)) * **deps:** update github/codeql-action digest to 28deaed ([#446](#446)) ([dfecd0c](dfecd0c)) * **deps:** update spec digest to 18cde17 ([#395](#395)) ([5608dfb](5608dfb)) * **deps:** update spec digest to 2ba05d8 ([#452](#452)) ([eb688c4](eb688c4)) * **deps:** update spec digest to 36944c6 ([#450](#450)) ([e162169](e162169)) * **deps:** update spec digest to d27e000 ([#455](#455)) ([e0ec8ca](e0ec8ca)) * packages read in release please ([1acc00f](1acc00f)) * update release permissions ([d0bf40b](d0bf40b)) * **workflows:** Add permissions for contents and pull-requests ([#439](#439)) ([568722a](568722a)) ### 📚 Documentation * update documentation on SetProviderAsync ([#449](#449)) ([858b286](858b286)) * Update README with spec version ([#437](#437)) ([7318b81](7318b81)), closes [#204](#204) ### 🔄 Refactoring * InMemoryProvider throwing when types mismatched ([#442](#442)) ([8ecf50d](8ecf50d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
WeihanLi
pushed a commit
to WeihanLi/openfeature-dotnet-sdk
that referenced
this pull request
May 14, 2025
…re#442) <!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> - Update InMemoryProvider to return an ErrorType with a default value instead of throwing exceptions - Add unit test to cover the new behavior ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes open-feature#441 ### Notes <!-- any additional notes for this PR --> ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> ### How to test <!-- if applicable, add testing instructions under this section --> Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com> Signed-off-by: Weihan Li <weihanli@outlook.com>
WeihanLi
pushed a commit
to WeihanLi/openfeature-dotnet-sdk
that referenced
this pull request
May 14, 2025
🤖 I have created a release *beep* *boop* --- ## [2.5.0](open-feature/dotnet-sdk@v2.4.0...v2.5.0) (2025-04-25) ### ✨ New Features * Add support for hook data. ([open-feature#387](open-feature#387)) ([4563512](open-feature@4563512)) ### 🧹 Chore * add NuGet auditing ([open-feature#454](open-feature#454)) ([42ab536](open-feature@42ab536)) * Change file scoped namespaces and cleanup job ([open-feature#453](open-feature#453)) ([1e74a04](open-feature@1e74a04)) * **deps:** update codecov/codecov-action action to v5.4.2 ([open-feature#432](open-feature#432)) ([c692ec2](open-feature@c692ec2)) * **deps:** update github/codeql-action digest to 28deaed ([open-feature#446](open-feature#446)) ([dfecd0c](open-feature@dfecd0c)) * **deps:** update spec digest to 18cde17 ([open-feature#395](open-feature#395)) ([5608dfb](open-feature@5608dfb)) * **deps:** update spec digest to 2ba05d8 ([open-feature#452](open-feature#452)) ([eb688c4](open-feature@eb688c4)) * **deps:** update spec digest to 36944c6 ([open-feature#450](open-feature#450)) ([e162169](open-feature@e162169)) * **deps:** update spec digest to d27e000 ([open-feature#455](open-feature#455)) ([e0ec8ca](open-feature@e0ec8ca)) * packages read in release please ([1acc00f](open-feature@1acc00f)) * update release permissions ([d0bf40b](open-feature@d0bf40b)) * **workflows:** Add permissions for contents and pull-requests ([open-feature#439](open-feature#439)) ([568722a](open-feature@568722a)) ### 📚 Documentation * update documentation on SetProviderAsync ([open-feature#449](open-feature#449)) ([858b286](open-feature@858b286)) * Update README with spec version ([open-feature#437](open-feature#437)) ([7318b81](open-feature@7318b81)), closes [open-feature#204](open-feature#204) ### 🔄 Refactoring * InMemoryProvider throwing when types mismatched ([open-feature#442](open-feature#442)) ([8ecf50d](open-feature@8ecf50d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Weihan Li <weihanli@outlook.com>
This was referenced Dec 18, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 19, 2025
Closed
Closed
This was referenced Jan 8, 2026
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #441
Notes
Follow-up Tasks
How to test