Merged
Conversation
Contributor
Author
|
Design was updated to include error state https://www.figma.com/design/gWXiUgpX9qeYz95LZlERe7/AdminUI-DS?node-id=3775-2068&p=f&m=dev. I'll update the Maykin-wide admin-ui to add this styling addition. PR: maykinmedia/admin-ui#299 |
robinmolen
force-pushed
the
feature/26-formik-controlled-checkbox
branch
from
56db872 to
e13abc4
Compare
robinmolen
changed the base branch from
feature/12-form-context
to
feature/26-form-field-helpers
robinmolen
force-pushed
the
feature/26-form-field-helpers
branch
from
53189f6 to
bf1fdd8
Compare
robinmolen
force-pushed
the
feature/26-formik-controlled-checkbox
branch
from
e13abc4 to
9701635
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 77.73% 77.61% -0.12%
==========================================
Files 36 37 +1
Lines 265 277 +12
Branches 47 51 +4
==========================================
+ Hits 206 215 +9
- Misses 53 56 +3
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SonnyBA
reviewed
Mar 17, 2026
SonnyBA
left a comment
SonnyBA
left a comment
There was a problem hiding this comment.
Looks good, although I think the name of the props for the Toggle component will cause some confusion.
SonnyBA
reviewed
Mar 17, 2026
robinmolen
force-pushed
the
feature/26-formik-controlled-checkbox
branch
from
9701635 to
7bca1ec
Compare
SonnyBA
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly closes #26
Depends on #28
Adding a Formik controlled checkbox component, and some form input helper components (Label and FormField)
The error message and error state isn't finalized yet, so this might change in later iterations