Skip to content

General configuration link button#50

Draft
robinmolen wants to merge 3 commits intomainfrom
feature/49-general-configuration-link-button
Draft

General configuration link button#50
robinmolen wants to merge 3 commits intomainfrom
feature/49-general-configuration-link-button

Conversation

@robinmolen
Copy link
Copy Markdown
Contributor

@robinmolen robinmolen commented Mar 23, 2026

Closes #49

Add djangoUrls to the AdminSettingsContext and add the GeneralConfigurationButton component.

The GeneralConfigurationButton component implements a HTML Anchor element, using the djangoUrls.generalConfiguration url as target.

The djangoUrls dict will contain any urls that are defined by implementing Django application. We assume that these urls will be created using the python reverse function, to ensure that the urls are and remain correct.

The urls defined in `djangoUrls` should be constructed using the Python `reserve` function, to ensure that the urls are and remain correct.
@robinmolen robinmolen requested a review from stefrado March 23, 2026 13:34
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.20%. Comparing base (f5e1ec5) to head (7a5977b).

Files with missing lines Patch % Lines
src/AdminUI.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   78.59%   78.20%   -0.40%     
==========================================
  Files          37       38       +1     
  Lines         285      289       +4     
  Branches       51       51              
==========================================
+ Hits          224      226       +2     
- Misses         55       57       +2     
  Partials        6        6              
Flag Coverage Δ
storybook 71.62% <83.33%> (+0.39%) ⬆️
vitest 46.40% <20.00%> (-1.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robinmolen robinmolen force-pushed the feature/49-general-configuration-link-button branch from 4aefe50 to 7a5977b Compare March 23, 2026 13:36
@robinmolen robinmolen marked this pull request as draft March 24, 2026 08:56
@robinmolen
Copy link
Copy Markdown
Contributor Author

The login url should also be provided through the djangoUrls #40. Might as well fix that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "go to general settings" button

1 participant