Skip to content

[#5716] api documentation doesnt mentions location header#6095

Open
KaczuH wants to merge 5 commits intoopen-formulieren:mainfrom
KaczuH:bug/5716-api-documentation-doesnt-mentions-location-header
Open

[#5716] api documentation doesnt mentions location header#6095
KaczuH wants to merge 5 commits intoopen-formulieren:mainfrom
KaczuH:bug/5716-api-documentation-doesnt-mentions-location-header

Conversation

@KaczuH
Copy link
Copy Markdown

@KaczuH KaczuH commented Mar 18, 2026

Closes #5716

Changes

Extend AutoSchema - Location header is auto-documented for create operations

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Checked new model fields are usable in the admin
    • Problem detection in the admin email digest is handled
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how
  • Documentation

    • Added documentation which describes the changes

@sergei-maertens
Copy link
Copy Markdown
Member

sergei-maertens commented Mar 23, 2026

Hi and thanks for the contribution! Our review backlog is currently a bit long, but don't worry - we'll get to this PR soon!

I've approved the CI pipeline so you at least get the automated feedback :-)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.09%. Comparing base (74824ca) to head (cc16f45).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6095   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files         880      880           
  Lines       33003    33019   +16     
  Branches     2950     2952    +2     
=======================================
+ Hits        32043    32059   +16     
  Misses        646      646           
  Partials      314      314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KaczuH
Copy link
Copy Markdown
Author

KaczuH commented Mar 23, 2026

Hi and thanks for the contribution! Our review backlog is currently a bit long, but don't worry - we'll get to this PR soon!

I've approved the CI pipeline so you at least get the automated feedback :-)

No worries, i get it!
Thanks!

@KaczuH KaczuH force-pushed the bug/5716-api-documentation-doesnt-mentions-location-header branch from 844b5b8 to de0c6c9 Compare March 25, 2026 09:52
@KaczuH
Copy link
Copy Markdown
Author

KaczuH commented Mar 27, 2026

@sergei-maertens Thanks for thorough review. Hope i've addressed all problems you've pointed out.

@KaczuH KaczuH requested a review from sergei-maertens March 27, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Api documentation doesn't mentions 'Location' header

2 participants