fix: observability alert and incident manager header style#26467
fix: observability alert and incident manager header style#26467ShaileshParmar11 merged 4 commits intomainfrom
Conversation
openmetadata-ui/src/main/resources/ui/src/pages/IncidentManager/IncidentManagerPage.tsx
Show resolved
Hide resolved
|
@ShaileshParmar11 I've opened a new pull request, #26469, to work on those changes. Once the pull request is ready, I'll request review from you. |
…ions (#26469) * Initial plan * fix: add `t` to useMemo dependency arrays in IncidentManagerPage and ObservabilityAlertsPage Co-authored-by: ShaileshParmar11 <71748675+ShaileshParmar11@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ShaileshParmar11 <71748675+ShaileshParmar11@users.noreply.github.com>
Code Review ✅ Approved 1 resolved / 1 findingsFixes observability alert and incident manager header styling while addressing a missing ✅ 1 resolved✅ Bug: useMemo with empty deps array omits
|
| Auto-apply | Compact |
|
|
Was this helpful? React with 👍 / 👎 | Gitar
|
🟡 Playwright Results — all passed (25 flaky)✅ 3313 passed · ❌ 0 failed · 🟡 25 flaky · ⏭️ 183 skipped
🟡 25 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
|
Changes have been cherry-picked to the 1.12.2 branch. |
* fix: observability alert and incident manager header style * minor fix * fix: add `t` to useMemo dependency arrays for pageHeaderData translations (#26469) * Initial plan * fix: add `t` to useMemo dependency arrays in IncidentManagerPage and ObservabilityAlertsPage Co-authored-by: ShaileshParmar11 <71748675+ShaileshParmar11@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ShaileshParmar11 <71748675+ShaileshParmar11@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> (cherry picked from commit 5928720)



Fixes: #26468
This pull request refactors the UI for the Incident Manager and Observability Alerts pages, focusing on improving header presentation and updating test cases to match these changes. The main improvements include replacing custom header layouts with the shared
PageHeadercomponent wrapped in an Ant DesignCard, updating translation keys for consistency, and adjusting tests to match new data-testid attributes and text.UI component refactoring:
IncidentManagerPageandObservabilityAlertsPagewith the sharedPageHeadercomponent, wrapped in aCardfor a more unified look and easier maintenance. (openmetadata-ui/src/main/resources/ui/src/pages/IncidentManager/IncidentManagerPage.tsx, [1] (openmetadata-ui/src/main/resources/ui/src/pages/ObservabilityAlertsPage/ObservabilityAlertsPage.tsx, [2] [3]openmetadata-ui/src/main/resources/ui/src/pages/IncidentManager/IncidentManagerPage.tsx, [1] (openmetadata-ui/src/main/resources/ui/src/pages/ObservabilityAlertsPage/ObservabilityAlertsPage.tsx, [2]Translation and header consistency:
'label.observability'to'label.observability-alert'and updated page header data accordingly for consistency across the UI. (openmetadata-ui/src/main/resources/ui/src/pages/ObservabilityAlertsPage/ObservabilityAlertsPage.tsx, openmetadata-ui/src/main/resources/ui/src/pages/ObservabilityAlertsPage/ObservabilityAlertsPage.tsxL288-R288)Test updates:
heading,sub-heading) and revised expected text values to match the new translation keys and header structure. (openmetadata-ui/src/main/resources/ui/src/pages/IncidentManager/IncidentManagerPage.test.tsx, [1] (openmetadata-ui/src/main/resources/ui/src/pages/ObservabilityAlertsPage/ObservabilityAlertsPage.test.tsx, [2]