[Refactor] Refactor standard roi head with boxlist.#8658
Merged
ZwwWayne merged 19 commits intoopen-mmlab:dev-3.xfrom Sep 28, 2022
Merged
[Refactor] Refactor standard roi head with boxlist.#8658ZwwWayne merged 19 commits intoopen-mmlab:dev-3.xfrom
ZwwWayne merged 19 commits intoopen-mmlab:dev-3.xfrom
Conversation
ZwwWayne
reviewed
Aug 29, 2022
jbwang1997
force-pushed
the
standard_roi_head
branch
5 times, most recently
from
c9c0b7b to
e8305ca
Compare
RangiLyu
reviewed
Sep 5, 2022
jbwang1997
force-pushed
the
standard_roi_head
branch
from
e8305ca to
653bd31
Compare
3 tasks
chhluo
reviewed
Sep 6, 2022
jbwang1997
force-pushed
the
standard_roi_head
branch
from
653bd31 to
8a1ad50
Compare
Collaborator
|
LGTM |
chhluo
previously approved these changes
Sep 8, 2022
jbwang1997
force-pushed
the
standard_roi_head
branch
from
8a1ad50 to
1b118b8
Compare
jbwang1997
force-pushed
the
standard_roi_head
branch
from
1b118b8 to
e9cd3ff
Compare
ZwwWayne
reviewed
Sep 10, 2022
ZwwWayne
reviewed
Sep 10, 2022
ZwwWayne
reviewed
Sep 10, 2022
ZwwWayne
reviewed
Sep 10, 2022
Collaborator
Author
|
I also move all box operations into mmdet.structures.bbox. |
RangiLyu
reviewed
Sep 13, 2022
Member
RangiLyu
left a comment
RangiLyu
left a comment
There was a problem hiding this comment.
The word "boxlist" should be changed.
Collaborator
Author
I have replaced all |
RangiLyu
previously approved these changes
Sep 14, 2022
ZwwWayne
reviewed
Sep 14, 2022
ZwwWayne
previously approved these changes
Sep 14, 2022
jbwang1997
force-pushed
the
standard_roi_head
branch
from
aeede04 to
6320ae0
Compare
Collaborator
|
LGTM |
chhluo
reviewed
Sep 27, 2022
Collaborator
chhluo
left a comment
chhluo
left a comment
There was a problem hiding this comment.
LGTM. Please rebase it on the latest dev-3.x
jbwang1997
force-pushed
the
standard_roi_head
branch
from
53a32bd to
b293c8a
Compare
ZwwWayne
approved these changes
Sep 28, 2022
ZwwWayne
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Refactor standard roi head with boxlist
wait for merging of #8625
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist