Skip to content

[Algorithm] Support Circular Smooth Label (CSL, ECCV'20)#153

Merged
ZwwWayne merged 16 commits intoopen-mmlab:devfrom
yangxue0827:main
Mar 29, 2022
Merged

[Algorithm] Support Circular Smooth Label (CSL, ECCV'20)#153
ZwwWayne merged 16 commits intoopen-mmlab:devfrom
yangxue0827:main

Conversation

@yangxue0827
Copy link
Collaborator

@yangxue0827 yangxue0827 commented Mar 21, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support Circular Smooth Label (CSL, ECCV'20) for #117.
Special thanks to liuyanyi for his help.

Modification

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #153 (7349f30) into dev (4e39a45) will decrease coverage by 0.37%.
The diff coverage is 16.54%.

@@            Coverage Diff             @@
##              dev     #153      +/-   ##
==========================================
- Coverage   28.67%   28.30%   -0.38%     
==========================================
  Files         102      108       +6     
  Lines        6604     6967     +363     
  Branches      990     1048      +58     
==========================================
+ Hits         1894     1972      +78     
- Misses       4646     4927     +281     
- Partials       64       68       +4     
Flag Coverage Δ
unittests 28.29% <16.54%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/apis/inference.py 0.00% <ø> (ø)
mmrotate/core/anchor/anchor_generator.py 75.00% <ø> (ø)
mmrotate/datasets/pipelines/loading.py 30.43% <ø> (ø)
...ate/models/dense_heads/kfiou_rotate_retina_head.py 30.00% <ø> (ø)
...els/dense_heads/kfiou_rotate_retina_refine_head.py 25.00% <ø> (ø)
mmrotate/models/dense_heads/oriented_rpn_head.py 12.17% <ø> (ø)
mmrotate/models/dense_heads/rotated_anchor_head.py 10.12% <0.00%> (-0.64%) ⬇️
...e/models/dense_heads/rotated_retina_refine_head.py 25.00% <ø> (ø)
mmrotate/models/dense_heads/rotated_rpn_head.py 12.29% <ø> (ø)
mmrotate/models/dense_heads/sam_reppoints_head.py 8.65% <0.00%> (-0.03%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9a592...7349f30. Read the comment docs.

@zytx121 zytx121 linked an issue Mar 24, 2022 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +11 to +14
Paper:
URL: None
Title: 'Arbitrary-Oriented Object Detection with Circular Smooth Label'
README: configs/csl/README.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paper URL and README are incorrect. And need a Code field.

Copy link
Collaborator

@zytx121 zytx121 Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbwang1997 We previously referenced MMPose's metafile.yml setting, so there is no code field. Maybe, we could propose another PR later to modify it uniformly.

Copy link
Collaborator

@jbwang1997 jbwang1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a little metafile.yml error. Others look good to me.

@yangxue0827 yangxue0827 changed the title [Algorithm] Support Circular Smooth Label (CSL, ECCV'21) [Algorithm] Support Circular Smooth Label (CSL, ECCV'20) Mar 25, 2022
@zytx121 zytx121 requested a review from ZwwWayne March 25, 2022 07:03
@zytx121
Copy link
Collaborator

zytx121 commented Mar 26, 2022

The model's weights and logs have been uploaded.

@ZwwWayne ZwwWayne merged commit 92d7505 into open-mmlab:dev Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support CSL

6 participants