Skip to content

Comments

Fix bug in HRSCDataset with clasesswise=ture#175

Merged
ZwwWayne merged 1 commit intoopen-mmlab:devfrom
Justice-Eternal:hrsd_bug
Apr 1, 2022
Merged

Fix bug in HRSCDataset with clasesswise=ture#175
ZwwWayne merged 1 commit intoopen-mmlab:devfrom
Justice-Eternal:hrsd_bug

Conversation

@zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Apr 1, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

resolve #173

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121 zytx121 changed the base branch from main to dev April 1, 2022 03:48
Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #175 (b36dda0) into dev (96de045) will increase coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #175      +/-   ##
==========================================
+ Coverage   28.20%   28.30%   +0.10%     
==========================================
  Files         108      108              
  Lines        6967     6967              
  Branches     1048     1048              
==========================================
+ Hits         1965     1972       +7     
+ Misses       4933     4927       -6     
+ Partials       69       68       -1     
Flag Coverage Δ
unittests 28.29% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/datasets/hrsc.py 16.80% <0.00%> (ø)
mmrotate/datasets/builder.py 51.85% <0.00%> (+25.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a362cd3...b36dda0. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 27ad538 into open-mmlab:dev Apr 1, 2022
@jbwang1997 jbwang1997 mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

training HRSV2016 with clasesswise=ture, the error : 'HRSCDataset' object has no attribute 'CLASSES_ID'

4 participants