Skip to content

[Fix] Fix bug in rotated_reppoints_head#246

Merged
ZwwWayne merged 5 commits intoopen-mmlab:devfrom
yangxue0827:reppoints
Apr 29, 2022
Merged

[Fix] Fix bug in rotated_reppoints_head#246
ZwwWayne merged 5 commits intoopen-mmlab:devfrom
yangxue0827:reppoints

Conversation

@yangxue0827
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Modification

all_overlaps_rotate_list = [None] * 4 -> all_overlaps_rotate_list = [None] * len(proposals_list)

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

ZwwWayne and others added 5 commits March 14, 2022 13:38
Bump version to v0.1.1
* [Docs] Update the introduction of SASM (AAAI'22)

* Update citation
* Update rotate_single_level_roi_extractor.py

* Update rotate_single_level_roi_extractor.py
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #246 (1ddb548) into dev (44b0aec) will increase coverage by 1.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #246      +/-   ##
==========================================
+ Coverage   28.30%   29.30%   +1.00%     
==========================================
  Files         108      113       +5     
  Lines        6967     7299     +332     
  Branches     1048     1110      +62     
==========================================
+ Hits         1972     2139     +167     
- Misses       4927     5084     +157     
- Partials       68       76       +8     
Flag Coverage Δ
unittests 29.27% <0.00%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...otate/models/dense_heads/rotated_reppoints_head.py 6.82% <0.00%> (ø)
...oi_extractors/rotate_single_level_roi_extractor.py 23.07% <0.00%> (-0.37%) ⬇️
mmrotate/models/detectors/oriented_rcnn.py 41.17% <0.00%> (-42.16%) ⬇️
mmrotate/core/visualization/image.py 68.57% <0.00%> (-7.43%) ⬇️
...ate/models/roi_heads/oriented_standard_roi_head.py 16.66% <0.00%> (-0.32%) ⬇️
mmrotate/models/roi_heads/roi_trans_roi_head.py 11.88% <0.00%> (-0.26%) ⬇️
mmrotate/apis/train.py 0.00% <0.00%> (ø)
mmrotate/datasets/sar.py 100.00% <0.00%> (ø)
mmrotate/datasets/dota.py 15.78% <0.00%> (ø)
mmrotate/utils/__init__.py 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b0aec...1ddb548. Read the comment docs.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121 zytx121 requested a review from liuyanyi April 27, 2022 02:16
Copy link
Collaborator

@liuyanyi liuyanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121 zytx121 mentioned this pull request Apr 28, 2022
@ZwwWayne ZwwWayne merged commit 434911c into open-mmlab:dev Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] An error occurs in rotate_reppoints_head after modifying samples_per_gpu

5 participants