Skip to content

[Enhance] Support mask in merge_results and huge_image_demo.py.#280

Merged
ZwwWayne merged 2 commits intoopen-mmlab:mainfrom
jbwang1997:mask_support
May 11, 2022
Merged

[Enhance] Support mask in merge_results and huge_image_demo.py.#280
ZwwWayne merged 2 commits intoopen-mmlab:mainfrom
jbwang1997:mask_support

Conversation

@jbwang1997
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

solve #276.
Support mask in merge_results.
Support instance segmantation models in huge_image_demo.py

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #280 (6129497) into main (1828f38) will decrease coverage by 0.00%.
The diff coverage is 6.45%.

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   31.52%   31.51%   -0.01%     
==========================================
  Files         113      113              
  Lines        7379     7346      -33     
  Branches     1138     1126      -12     
==========================================
- Hits         2326     2315      -11     
+ Misses       4946     4929      -17     
+ Partials      107      102       -5     
Flag Coverage Δ
unittests 31.48% <6.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/apis/inference.py 0.00% <ø> (ø)
mmrotate/core/patch/merge_results.py 9.23% <6.45%> (-11.83%) ⬇️
mmrotate/models/dense_heads/rotated_rpn_head.py 12.29% <0.00%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1828f38...6129497. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 0edd257 into open-mmlab:main May 11, 2022
ZwwWayne added a commit that referenced this pull request May 18, 2022
* [Docs] Update the introduction of SASM (AAAI'22) (#184)

* [Docs] Update the introduction of SASM (AAAI'22)

* Update citation

* [Fix] 'RoIAlignRotated' object has no attribute 'output_size' (#213)

* Update rotate_single_level_roi_extractor.py

* Update rotate_single_level_roi_extractor.py

* [Fix]  Modify the use of rotated anchor inside flags (#197)

* rotated RPN bug

* Modify the use of rotated anchor inside flags

* Added PolyDiscreteRotate transform and fixed typos

* Added unit test for PolyDiscreteRotate

* Fixed linting of pipelines __init__

* Fused the 2 transforms

* [Enhance] Support mask in merge_results and huge_image_demo.py. (#280)

* Support masks mergeing

* Update error report

* Added mode argument

* Fixed redundancy and added value unit test

Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
Co-authored-by: yangxue <yangxue0827@126.com>
Co-authored-by: Yue Zhou <592267829@qq.com>
Co-authored-by: GamblerZSY <86358394+GamblerZSY@users.noreply.github.com>
Co-authored-by: jbwang1997 <jbwang1997@gmail.com>
@zytx121 zytx121 mentioned this pull request Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants