Skip to content

Fix HRSC filename#329

Merged
ZwwWayne merged 1 commit intoopen-mmlab:devfrom
liuyanyi:fix_hrsc_filename
Jun 6, 2022
Merged

Fix HRSC filename#329
ZwwWayne merged 1 commit intoopen-mmlab:devfrom
liuyanyi:fix_hrsc_filename

Conversation

@liuyanyi
Copy link
Collaborator

@liuyanyi liuyanyi commented Jun 1, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add img_prefix for HRSC Datset.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #329 (cac182c) into dev (3055b56) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #329      +/-   ##
==========================================
- Coverage   31.59%   31.57%   -0.03%     
==========================================
  Files         113      113              
  Lines        7355     7354       -1     
  Branches     1128     1128              
==========================================
- Hits         2324     2322       -2     
+ Misses       4929     4928       -1     
- Partials      102      104       +2     
Flag Coverage Δ
unittests 31.57% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/datasets/hrsc.py 18.03% <0.00%> (ø)
mmrotate/utils/setup_env.py 88.00% <0.00%> (-4.00%) ⬇️
mmrotate/datasets/builder.py 48.14% <0.00%> (-3.71%) ⬇️
mmrotate/apis/inference.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b04a80...cac182c. Read the comment docs.

@zytx121 zytx121 mentioned this pull request Jun 5, 2022
@ZwwWayne ZwwWayne merged commit 834e8f9 into open-mmlab:dev Jun 6, 2022
@yangxue0827 yangxue0827 mentioned this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants