Skip to content

Update readme and install.md#342

Merged
ZwwWayne merged 7 commits intoopen-mmlab:devfrom
Justice-Eternal:readme
Jun 10, 2022
Merged

Update readme and install.md#342
ZwwWayne merged 7 commits intoopen-mmlab:devfrom
Justice-Eternal:readme

Conversation

@zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Jun 9, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121 zytx121 changed the base branch from main to dev June 9, 2022 03:10
Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #342 (ae2a366) into dev (d6ff82d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #342   +/-   ##
=======================================
  Coverage   30.86%   30.86%           
=======================================
  Files         119      119           
  Lines        7934     7934           
  Branches     1220     1220           
=======================================
  Hits         2449     2449           
  Misses       5384     5384           
  Partials      101      101           
Flag Coverage Δ
unittests 30.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6ff82d...ae2a366. Read the comment docs.

Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit ad47951 into open-mmlab:dev Jun 10, 2022
@zytx121 zytx121 mentioned this pull request Jul 1, 2022
zytx121 added a commit to Justice-Eternal/mmrotate that referenced this pull request Jul 6, 2022
* update

* update

* update

* fix

* 使用 Colaboratory 创建

* update

* fix lint
@zytx121 zytx121 mentioned this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants