Skip to content

'mmrotate\apis\inference.py'#368

Merged
ZwwWayne merged 1 commit intoopen-mmlab:mainfrom
sltlls:develop
Jun 22, 2022
Merged

'mmrotate\apis\inference.py'#368
ZwwWayne merged 1 commit intoopen-mmlab:mainfrom
sltlls:develop

Conversation

@sltlls
Copy link
Contributor

@sltlls sltlls commented Jun 18, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

When using demo/huge_image_demo.py to inference large image with large gap set, it will meet the problem of memory shortage.

Modification

Change the patch_datas variable from saving all data of splited images to only saving data of splited images in one batch.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121
Copy link
Collaborator

zytx121 commented Jun 20, 2022

@jbwang1997 Please have a look.

@zytx121 zytx121 requested a review from jbwang1997 June 20, 2022 01:43
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #368 (71969de) into main (e22c8df) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   30.86%   30.85%   -0.01%     
==========================================
  Files         119      119              
  Lines        7934     7936       +2     
  Branches     1220     1221       +1     
==========================================
  Hits         2449     2449              
- Misses       5384     5386       +2     
  Partials      101      101              
Flag Coverage Δ
unittests 30.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/apis/inference.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22c8df...71969de. Read the comment docs.

Copy link
Collaborator

@jbwang1997 jbwang1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sltlls
Copy link
Contributor Author

sltlls commented Jun 21, 2022

What does the sentence “Added line #L56 was not covered by tests” mean?

@ZwwWayne ZwwWayne changed the base branch from main to dev June 22, 2022 12:29
@ZwwWayne ZwwWayne changed the base branch from dev to main June 22, 2022 12:30
@ZwwWayne ZwwWayne merged commit 01439d1 into open-mmlab:main Jun 22, 2022
@ZwwWayne
Copy link
Collaborator

What does the sentence “Added line #L56 was not covered by tests” mean?

It means the unit tests do not fully test that line of code.

This was referenced Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants