Merged
Conversation
zytx121
reviewed
Oct 9, 2022
zytx121
reviewed
Oct 9, 2022
RangiLyu
reviewed
Oct 11, 2022
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Compared with 0.x, Rotated FCOSHead and CSLFCOSHead merged together.
Added a argument
use_hbbox_lossto replaceseparate_angleto make it better understanding.Before:
Arg
separate_anglecontrol the type of bbox_loss used and whether angle loss is enabled.After:
Arg
use_hbbox_losscontrol the type of bbox_loss. Whether angle loss is enabled is controlled byloss_angle.In this case we can use Rotated IoU Loss and L1Loss together, Rotated IoU Loss for bbox, L1 for angle auxiliary losses.
Results:
Note: The result is not stable and may have 1% ap difference. Training process may have unstable too.
We should do some exps on tricks and losses to find the best config settings.
Add l1 loss for angle, results does not appear to have improved, but it has not decreased either.
Modification
F.cosine_similaritytypo in oriented_reppointsencode_sizeBC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist