Skip to content

Refactor structure of mmrotate#558

Merged
RangiLyu merged 10 commits intoopen-mmlab:dev-1.xfrom
Justice-Eternal:refactor_structure
Oct 21, 2022
Merged

Refactor structure of mmrotate#558
RangiLyu merged 10 commits intoopen-mmlab:dev-1.xfrom
Justice-Eternal:refactor_structure

Conversation

@zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Oct 20, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Refactor structure of mmrotate.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RangiLyu RangiLyu merged commit 288481f into open-mmlab:dev-1.x Oct 21, 2022
@l4d2boomer
Copy link

@zytx121 I am wondering why almost all files in the detector folder have deleted. 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants