Skip to content

Fix rbbox_overlaps abnormal when the box is too small.#61

Merged
ZwwWayne merged 5 commits intoopen-mmlab:devfrom
Justice-Eternal:rbbox_overlaps_abnormal
Mar 9, 2022
Merged

Fix rbbox_overlaps abnormal when the box is too small.#61
ZwwWayne merged 5 commits intoopen-mmlab:devfrom
Justice-Eternal:rbbox_overlaps_abnormal

Conversation

@zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Mar 3, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix rbbox_overlaps abnormal when the box is too small.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121 zytx121 linked an issue Mar 3, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #61 (2abe12e) into dev (dd40984) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #61      +/-   ##
==========================================
+ Coverage   28.76%   28.87%   +0.11%     
==========================================
  Files         102      102              
  Lines        6571     6573       +2     
  Branches      985      985              
==========================================
+ Hits         1890     1898       +8     
+ Misses       4617     4609       -8     
- Partials       64       66       +2     
Flag Coverage Δ
unittests 28.86% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/bbox/iou_calculators/rotate_iou2d_calculator.py 53.57% <100.00%> (+26.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd40984...2abe12e. Read the comment docs.

@zytx121 zytx121 requested a review from yangxue0827 March 3, 2022 16:06
Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The output of 'rbbox_overlaps' is abnormal when bbox is too small

4 participants