Skip to content

[Fix] fix get_flops.py#646

Merged
RangiLyu merged 1 commit intoopen-mmlab:dev-1.xfrom
yxzhao2022:fix_get_flops
Nov 28, 2022
Merged

[Fix] fix get_flops.py#646
RangiLyu merged 1 commit intoopen-mmlab:dev-1.xfrom
yxzhao2022:fix_get_flops

Conversation

@yxzhao2022
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Update get_flops.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 60.95% // Head: 79.73% // Increases project coverage by +18.77% 🎉

Coverage data is based on head (449d60e) compared to base (e4ae563).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x     #646       +/-   ##
============================================
+ Coverage    60.95%   79.73%   +18.77%     
============================================
  Files           95       95               
  Lines         6460     6460               
  Branches       915      915               
============================================
+ Hits          3938     5151     +1213     
+ Misses        2315     1011     -1304     
- Partials       207      298       +91     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/evaluation/metrics/dota_metric.py 87.00% <0.00%> (-1.13%) ⬇️
mmrotate/models/task_modules/coders/angle_coder.py 44.55% <0.00%> (+1.98%) ⬆️
mmrotate/testing/_utils.py 83.62% <0.00%> (+5.17%) ⬆️
.../task_modules/assigners/rotate_iou2d_calculator.py 67.36% <0.00%> (+5.26%) ⬆️
mmrotate/models/dense_heads/rotated_fcos_head.py 68.85% <0.00%> (+6.55%) ⬆️
mmrotate/models/roi_heads/gv_ratio_roi_head.py 75.00% <0.00%> (+8.33%) ⬆️
...els/task_modules/coders/delta_xywht_hbbox_coder.py 99.13% <0.00%> (+17.24%) ⬆️
mmrotate/utils/misc.py 42.85% <0.00%> (+21.42%) ⬆️
...rotate/models/roi_heads/bbox_heads/gv_bbox_head.py 79.18% <0.00%> (+25.71%) ⬆️
.../task_modules/coders/distance_angle_point_coder.py 53.84% <0.00%> (+26.92%) ⬆️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RangiLyu RangiLyu merged commit b41a291 into open-mmlab:dev-1.x Nov 28, 2022
@zytx121 zytx121 mentioned this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants