Skip to content

[Fix] sklearn depreated, install scikit-learn#658

Merged
RangiLyu merged 3 commits intoopen-mmlab:devfrom
nijkah:fix/scikitlearn
Dec 15, 2022
Merged

[Fix] sklearn depreated, install scikit-learn#658
RangiLyu merged 3 commits intoopen-mmlab:devfrom
nijkah:fix/scikitlearn

Conversation

@nijkah
Copy link
Contributor

@nijkah nijkah commented Dec 13, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      The 'sklearn' PyPI package is deprecated, use 'scikit-learn'
      rather than 'sklearn' for pip commands.
      

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RangiLyu RangiLyu merged commit 08d1055 into open-mmlab:dev Dec 15, 2022
@nijkah nijkah deleted the fix/scikitlearn branch December 15, 2022 06:19
@RangiLyu RangiLyu mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants