Skip to content

Add Colab Tutorial#66

Merged
ZwwWayne merged 20 commits intoopen-mmlab:devfrom
Justice-Eternal:colab
Mar 8, 2022
Merged

Add Colab Tutorial#66
ZwwWayne merged 20 commits intoopen-mmlab:devfrom
Justice-Eternal:colab

Conversation

@zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Mar 3, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add Colab Tutorial.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #66 (2445646) into dev (dd40984) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #66   +/-   ##
=======================================
  Coverage   28.76%   28.76%           
=======================================
  Files         102      102           
  Lines        6571     6571           
  Branches      985      985           
=======================================
  Hits         1890     1890           
  Misses       4617     4617           
  Partials       64       64           
Flag Coverage Δ
unittests 28.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd40984...2445646. Read the comment docs.

Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jbwang1997 jbwang1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Mar 4, 2022

  1. we should not use dev branch but should recommend users to use the released master branch
  2. suggest renaming it as inference_demo.ipynb

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Mar 4, 2022

Should we also teach users how to train the model on a new dataset?

@zytx121
Copy link
Collaborator Author

zytx121 commented Mar 5, 2022

  1. we should not use dev branch but should recommend users to use the released master branch
  2. suggest renaming it as inference_demo.ipynb

There is a bug in the master branch that will cause an error when running the demo. This bug has been fixed in the dev branch. So currently only the dev branch can be used.

@zytx121
Copy link
Collaborator Author

zytx121 commented Mar 5, 2022

Should we also teach users how to train the model on a new dataset?

OK, I will try it.

@jbwang1997
Copy link
Collaborator

image
The downloading command has been commented.

@zytx121 zytx121 changed the title Add Colab Tutorial [WIP] Add Colab Tutorial Mar 6, 2022
@zytx121 zytx121 added the WIP label Mar 6, 2022
@zytx121
Copy link
Collaborator Author

zytx121 commented Mar 7, 2022

  1. we should not use dev branch but should recommend users to use the released master branch
  2. suggest renaming it as inference_demo.ipynb

@ZwwWayne Since we added a section about how to train the model on a new dataset, should we rename it or not?

@zytx121 zytx121 removed the WIP label Mar 8, 2022
@zytx121 zytx121 changed the title [WIP] Add Colab Tutorial Add Colab Tutorial Mar 8, 2022
@ZwwWayne ZwwWayne merged commit cd8ffb2 into open-mmlab:dev Mar 8, 2022
@zytx121 zytx121 mentioned this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants