Skip to content

[Enhance] use iof for RRandomCrop validation#660

Merged
RangiLyu merged 4 commits intoopen-mmlab:devfrom
nijkah:feature/rcrop
Dec 19, 2022
Merged

[Enhance] use iof for RRandomCrop validation#660
RangiLyu merged 4 commits intoopen-mmlab:devfrom
nijkah:feature/rcrop

Conversation

@nijkah
Copy link
Contributor

@nijkah nijkah commented Dec 13, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Previously, valid_rbboxes are determined with their center points.
Following

, replace it with more appropriate criteria: IoF(Intersection over foreground)

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 29.44% // Head: 29.48% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (bdf0c6f) compared to base (bc1ced4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #660      +/-   ##
==========================================
+ Coverage   29.44%   29.48%   +0.03%     
==========================================
  Files         121      121              
  Lines        8500     8504       +4     
  Branches     1279     1279              
==========================================
+ Hits         2503     2507       +4     
  Misses       5896     5896              
  Partials      101      101              
Flag Coverage Δ
unittests 29.45% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/datasets/pipelines/transforms.py 66.37% <100.00%> (+0.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RangiLyu RangiLyu merged commit b2f7ff2 into open-mmlab:dev Dec 19, 2022
@zytx121 zytx121 mentioned this pull request Dec 30, 2022
@RangiLyu RangiLyu mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants