[Enhance] use iof for RRandomCrop validation#660
Merged
RangiLyu merged 4 commits intoopen-mmlab:devfrom Dec 19, 2022
Merged
Conversation
zytx121
approved these changes
Dec 14, 2022
Codecov ReportBase: 29.44% // Head: 29.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #660 +/- ##
==========================================
+ Coverage 29.44% 29.48% +0.03%
==========================================
Files 121 121
Lines 8500 8504 +4
Branches 1279 1279
==========================================
+ Hits 2503 2507 +4
Misses 5896 5896
Partials 101 101
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Previously, valid_rbboxes are determined with their center points.
Following
mmrotate/tools/data/dota/split/img_split.py
Line 79 in bc1ced4
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist