targetEnforcementAction key should take care of the object kind#510
Merged
ritazh merged 1 commit intoopen-policy-agent:masterfrom Jan 15, 2025
Merged
Conversation
Signed-off-by: Steeve Chailloux <me@steeve.io>
JaydipGabani
approved these changes
Jan 10, 2025
Contributor
JaydipGabani
left a comment
JaydipGabani
left a comment
There was a problem hiding this comment.
Thanks for PR! LGTM
maxsmythe
approved these changes
Jan 15, 2025
Contributor
maxsmythe
left a comment
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
==========================================
- Coverage 54.68% 53.44% -1.25%
==========================================
Files 71 97 +26
Lines 5241 6117 +876
==========================================
+ Hits 2866 3269 +403
- Misses 2073 2513 +440
- Partials 302 335 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ritazh
approved these changes
Jan 15, 2025
Member
ritazh
left a comment
ritazh
left a comment
There was a problem hiding this comment.
Thanks for the fix!!!
@JaydipGabani need to bump framework in GK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: open-policy-agent/gatekeeper#3772