Enable ntruprime sntrup761

[loganaden]

No description provided.

[thomwiggers]

You missed a feature which is required for this to build correctly. Once that's added, this should be ready to be merged.

[loganaden]

It appears that the branch needs to be merged with the latest commit from @thomwiggers before it's merged automatically ?I've done this. Waiting for the next CI run to be allowed.

[thomwiggers]

I wish "approve and run" would stick, but alas. Okay, this should finally go through when CI passes now.

[thomwiggers]

Thanks :)

[Sculas]

I was taking a look at the codebase, and I noticed that NTRU Prime was missing from here:

liboqs-rust/oqs-sys/build.rs

Lines 61 to 78 in 6918c27

	// KEMs
	// BIKE is not supported on Windows or Arm32, so if either is in the mix,
	// have it be opt-in explicitly except through the default kems feature.
	if cfg!(feature = "kems") && !(cfg!(windows) || cfg!(target_arch = "arm")) {
	println!("cargo:rustc-cfg=feature=\"bike\"");
	config.define("OQS_ENABLE_KEM_BIKE", "Yes");
	} else {
	algorithm_feature!("KEM", "bike");
	}
	algorithm_feature!("KEM", "classic_mceliece");
	algorithm_feature!("KEM", "frodokem");
	algorithm_feature!("KEM", "hqc");
	algorithm_feature!("KEM", "kyber");
	// signature schemes
	algorithm_feature!("SIG", "dilithium");
	algorithm_feature!("SIG", "falcon");
	algorithm_feature!("SIG", "sphincs");

This made me think that the NTRU Prime algorithm would always be disabled, but tests are saying otherwise.
How can it be that NTRU Prime is being linked without it being toggled on? Does it default to being linked?

[thomwiggers]

I imagine that if the feature flags are not set, the default takes over.