Allow finding and linking system deps#211
Allow finding and linking system deps#211thomwiggers merged 2 commits intoopen-quantum-safe:mainfrom
Conversation
|
Oops, meant for this to be a draft for now. |
|
Ping @wucke13 for discussion |
59341ea to
ca50698
Compare
ca50698 to
14d298a
Compare
thomwiggers
left a comment
There was a problem hiding this comment.
Overall this looks pretty reasonable, but I have a few questions/suggestions
14d298a to
a949880
Compare
|
Added requested changes, split the code into some more includedir related functions to allow early return if |
thomwiggers
left a comment
There was a problem hiding this comment.
I have a minor gripe with the lower bound computation, and it would be great if you could document the vendored feature in the README.
a949880 to
efb537e
Compare
|
Added the suggested change and README docs. I was split between processing the patch version as an interger or as a str, but the latter seems more reliable, especially against versions like |
thomwiggers
left a comment
There was a problem hiding this comment.
Unfortunately, Cargo won't allow 001 and will simplify that to 1; otherwise I would have released version 000. But this seems good enough.
|
Shoot, I hadn't thought about this but |
|
And that is a problem for releasing updates :( |
|
I guess I also forgot something - an env var like Such a thing makes it easier for distros to manage a central liboqs package with e.g. sexurity vulnerabilities patched, as with SSL libraries. |
|
Sounds like a good addition |
Addresses #190
Adds necessary changes to optionally detect the system liboqs version and link to it.
To consider:
vendorfeature, or can we defer topkg-configcrate's env var configuration (e.g. "LIBOQS_NO_PKG_CONFIG")0.8.0&& <0.9.0) enough?Tested this manually with a system-installed build of liboqs 0.8.0-rc1. Not sure how best to test this in CI yet.