feat: consume openssl from openssl-sys#275
Merged
SWilson4 merged 5 commits intoopen-quantum-safe:mainfrom Jan 29, 2025
Merged
Conversation
Signed-off-by: James Mayclin <maycj@amazon.com>
Signed-off-by: James Mayclin <maycj@amazon.com>
Signed-off-by: James Mayclin <maycj@amazon.com>
Member
|
I think it makes sense to keep "vendored openssl" as a separate option from "vendored" (liboqs). What do you think about adding CI tests for each option? |
Signed-off-by: James Mayclin <maycj@amazon.com>
Signed-off-by: James Mayclin <maycj@amazon.com>
jmayclin
force-pushed
the
cmake-from-ossl-sys
branch
from
f0ef54e to
9b96c82
Compare
SWilson4
approved these changes
Jan 28, 2025
Contributor
Author
|
Thanks for the approval! Is there anything else needed to do before merging? |
Member
Nope, I'll hit the merge button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow liboqs-rust to use the OpenSSL pulled in from
openssl-sys.If a rust project wants to link several things against OpenSSL, it is easiest to use the standard
openssl-syspackage. This PR adds a new featurevendored_opensslthat will allow the vendored_openssl to be pulled in.Callouts
I added this as a totally separate feature, which preserves the current
OPENSSL_ROOT_DIRenvironment variable behavior.openssl-sysexpects openssl to be specified withOPENSSL_DIR, so it would be a breaking change.Alternately this "feature" could be the result if enabled both
opensslandvendored. E.g., if you want a vendored liboqs then you might also want a vendored openssl?