Skip to content

Improvements for attributes semconv generation #133

@lmolkova

Description

@lmolkova

open-telemetry/opentelemetry-specification#3183 declares attributes separately from traces and metrics and then reuses attributes in corresponding semconvs. There are two issues:

  1. Grandparent attributes are not populated in the table. E.g.

    • http.common group defines http.method
    • http.server group extends http.common and defines http.route
    • metric.http.server.duration extends http.server. When metric.http.server.duration(full) semconv table is rendered, it does not include http.method, but includes http.route
  2. Referenced attributes description should come from extended semconv first. E.g.

    • net.peer.name is defined in span-general semconv
    • it's redefined for HTTP in http.client.common providing long HTTP-specific description
    • it needs sampling_relevant: true for tracing (and none of it for metrics), so it has to be referenced again in trace.http.client and long HTTP-specific description should be repeated
    • Proposal: when resolving net.peer.name for trace.http.client semconv, it should prioritize properties from trace.http.client, then read them from parent (http.client.common) and finally fill in the gaps from original span-general spec.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsemconvRelated to the semantic convention generator.semconv/modelRelated to the data model or YAML format of the semantic convention generator

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions