-
Notifications
You must be signed in to change notification settings - Fork 58
Improvements for attributes semconv generation #133
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workingsemconvRelated to the semantic convention generator.Related to the semantic convention generator.semconv/modelRelated to the data model or YAML format of the semantic convention generatorRelated to the data model or YAML format of the semantic convention generator
Description
open-telemetry/opentelemetry-specification#3183 declares attributes separately from traces and metrics and then reuses attributes in corresponding semconvs. There are two issues:
-
Grandparent attributes are not populated in the table. E.g.
http.commongroup defineshttp.methodhttp.servergroup extendshttp.commonand defineshttp.routemetric.http.server.durationextendshttp.server. Whenmetric.http.server.duration(full)semconv table is rendered, it does not includehttp.method, but includeshttp.route
-
Referenced attributes description should come from extended semconv first. E.g.
net.peer.nameis defined in span-general semconv- it's redefined for HTTP in
http.client.commonproviding long HTTP-specific description - it needs
sampling_relevant: truefor tracing (and none of it for metrics), so it has to be referenced again intrace.http.clientand long HTTP-specific description should be repeated - Proposal: when resolving
net.peer.namefortrace.http.clientsemconv, it should prioritize properties fromtrace.http.client, then read them from parent (http.client.common) and finally fill in the gaps from original span-general spec.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingsemconvRelated to the semantic convention generator.Related to the semantic convention generator.semconv/modelRelated to the data model or YAML format of the semantic convention generatorRelated to the data model or YAML format of the semantic convention generator