Update README.md#252
Merged
jsuereth merged 8 commits intoopen-telemetry:mainfrom Feb 17, 2024
kennykguo:patch-1
Merged
Conversation
Updated the outdated links in the readme.md file to redirect user to the semantic-conventions folder.
lmolkova
approved these changes
Jan 8, 2024
joaopgrassi
reviewed
Jan 17, 2024
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Redundant sentence
wbh1
reviewed
Jan 19, 2024
Contributor
wbh1
left a comment
wbh1
left a comment
There was a problem hiding this comment.
Sorry to swoop in and drop a code review on a repo that I've never contributed to 🙈 But I noticed the same broken links while I going through the docs, saw this PR, and wanted to provide feedback rather than open a duplicative PR.
Accepted suggestion from wbh1 Co-authored-by: Will Hegedus <will@wbhegedus.me>
Accepted suggestion from wb1.
Contributor
Author
|
All comments have been accepted. Please let me know if there should be any more changes. |
joaopgrassi
reviewed
Jan 26, 2024
dev-jesse
reviewed
Jan 31, 2024
Accepted changes Co-authored-by: Jesse <83730324+dev-jesse@users.noreply.github.com>
jsuereth
approved these changes
Feb 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the outdated links in the readme.md file to redirect user to the semantic-conventions folder.
Original issue: #34