Add backward compatibility check mode#271
Merged
jsuereth merged 11 commits intoopen-telemetry:mainfrom Feb 24, 2024
Merged
Conversation
f04d093 to
2fcaafe
Compare
0744a57 to
fd3be67
Compare
fd3be67 to
761f193
Compare
trisch-me
reviewed
Feb 21, 2024
trisch-me
reviewed
Feb 21, 2024
jsuereth
approved these changes
Feb 21, 2024
Contributor
jsuereth
left a comment
There was a problem hiding this comment.
This is a great additiion! Thanks for putting this together.
- I echo Alexandra's concerns around download success. However, I don't feel the need to reapprove on fix.
- I had one other comment on additioinal stability checking we can do, but consider it non-blocking.
semantic-conventions/src/opentelemetry/semconv/templating/compatibility.py
Show resolved
Hide resolved
joaopgrassi
reviewed
Feb 22, 2024
Member
There was a problem hiding this comment.
This is great! Thanks for working on it.
Just a question I had while reviewing/reading the issue: Who is the target group of this new task in the tool? Like, when is it going to be executed? During a release of semconv? By SDK authors? Ran automatically as part of a CI/CD in semconv? It's not clear and maybe this should be stated somewhere?
semantic-conventions/src/tests/data/compat/enum_value_removed/vprev.yaml
Show resolved
Hide resolved
semantic-conventions/src/tests/data/markdown/enum_extend_list/expected.md
Outdated
Show resolved
Hide resolved
trisch-me
approved these changes
Feb 22, 2024
2 tasks
Member
Author
|
@joaopgrassi my intention is to add it to CI checks - here's draft PR that demonstrates it open-telemetry/semantic-conventions#764 |
joaopgrassi
approved these changes
Feb 23, 2024
2 tasks
lmolkova
pushed a commit
to lmolkova/build-tools
that referenced
this pull request
Feb 29, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements back-compat checks against released version
See open-telemetry/semantic-conventions#740 for the context
Usage:
-f path/to/semantic-conventions/model compatibility --previous-version 1.24.0If I run it against current semconv main, I get