Make stability required, fix ref and extends, render badges on metrics#272
Merged
Conversation
joaopgrassi
approved these changes
Feb 23, 2024
3 tasks
jsuereth
approved these changes
Feb 26, 2024
MSNev
approved these changes
Feb 26, 2024
4ca1a59 to
cacca12
Compare
arminru
approved these changes
Feb 27, 2024
arminru
added a commit
to dynatrace-oss-contrib/build-tools
that referenced
this pull request
Feb 27, 2024
arminru
added a commit
that referenced
this pull request
Feb 27, 2024
This was referenced Feb 28, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #267 (comment)
See open-telemetry/semantic-conventions#763
This PR:
It would result in all metrics and attributes, referenced or declared to be able to have a badge (can turn on/off with cmd arg) - example with everything on:
test.deprecated_experimental_attrtest.deprecated_stable_attrtest.exp_attrtest.stable_attrstable_metricsstable_metric
experimental_metric{e}experimental_metric
deprecated_metric{d}deprecated_metric
(PS: sorry for the huge PR, most of it is adding stability to all test data attributes 😴)