Skip to content

[exporter/debug]: disable sending queue by default#14151

Merged
mx-psi merged 1 commit intoopen-telemetry:mainfrom
andrzej-stencel:debug-exporter-disable-queue
Nov 12, 2025
Merged

[exporter/debug]: disable sending queue by default#14151
mx-psi merged 1 commit intoopen-telemetry:mainfrom
andrzej-stencel:debug-exporter-disable-queue

Conversation

@andrzej-stencel
Copy link
Member

Description

The recently added (#13791, #14101) sending queue functionality in the Debug exporter had a default size of 1, causing issue described in #14138.

I propose to disable the queue by default in the Debug exporter.

Link to tracking issue

Fixes #14138

Testing

Updated unit tests.

I would feel better if the queue scenarios where better covered by tests. On the other hand, I don't want to have similar queue/batching tests duplicated in all exporters.

Documentation

Updated documentation to say the sending queue is disabled by default.

@andrzej-stencel andrzej-stencel requested a review from a team as a code owner November 12, 2025 10:38
@andrzej-stencel andrzej-stencel changed the title [exporter/debug]: disable queue by default [exporter/debug]: disable sending queue by default Nov 12, 2025
@github-actions github-actions bot added the exporter/debug Issues related to the Debug exporter label Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (a9691ee) to head (86e74e4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14151      +/-   ##
==========================================
- Coverage   92.24%   92.24%   -0.01%     
==========================================
  Files         658      658              
  Lines       41168    41171       +3     
==========================================
  Hits        37977    37977              
- Misses       2184     2186       +2     
- Partials     1007     1008       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@VihasMakwana VihasMakwana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc: @codeboten

@mx-psi mx-psi added this pull request to the merge queue Nov 12, 2025
Merged via the queue into open-telemetry:main with commit 760fbbc Nov 12, 2025
60 of 61 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 12, 2025
@andrzej-stencel andrzej-stencel deleted the debug-exporter-disable-queue branch November 17, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exporter/debug Issues related to the Debug exporter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[exporter/debug] Default sending_queue size causes immediate export failures

3 participants