Skip to content

[pdata/pprofile] Update protoID for messsage Sample fields#14652

Merged
mx-psi merged 10 commits intoopen-telemetry:mainfrom
florianl:pprofile-proto-724
Mar 10, 2026
Merged

[pdata/pprofile] Update protoID for messsage Sample fields#14652
mx-psi merged 10 commits intoopen-telemetry:mainfrom
florianl:pprofile-proto-724

Conversation

@florianl
Copy link
Copy Markdown
Member

@florianl florianl commented Feb 27, 2026

Description

open-telemetry/opentelemetry-proto#724 introduces a breaking change to the Profiles signal.

This is a follow up to #14739.

Link to tracking issue

Fixes #

Testing

Documentation

open-telemetry/opentelemetry-proto#724 introduces a breaking change
to the Profiles signal.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl marked this pull request as ready for review March 10, 2026 08:07
@florianl florianl requested review from a team, dmathieu, dmitryax and mx-psi as code owners March 10, 2026 08:07
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl

This comment was marked as off-topic.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 10, 2026

Merging this PR will improve performance by 30.43%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 6 untouched benchmarks
⏩ 76 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
BenchmarkTraceSizeSpanCount 60 ns 46 ns +30.43%

Comparing florianl:pprofile-proto-724 (cf5054c) with main (fc354be)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@mx-psi mx-psi enabled auto-merge March 10, 2026 09:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.45%. Comparing base (fc354be) to head (cf5054c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pdata/internal/generated_proto_sample.go 90.90% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (91.30%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14652      +/-   ##
==========================================
- Coverage   91.45%   91.45%   -0.01%     
==========================================
  Files         688      688              
  Lines       43824    43824              
==========================================
- Hits        40081    40078       -3     
- Misses       2631     2633       +2     
- Partials     1112     1113       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi mx-psi added this pull request to the merge queue Mar 10, 2026
Merged via the queue into open-telemetry:main with commit 92c4252 Mar 10, 2026
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants