Skip to content

[Logs SDK] Log Appender for log4cxx#356

Merged
marcalff merged 15 commits intoopen-telemetry:mainfrom
chusitoo:Log4cxx_appender
Feb 8, 2024
Merged

[Logs SDK] Log Appender for log4cxx#356
marcalff merged 15 commits intoopen-telemetry:mainfrom
chusitoo:Log4cxx_appender

Conversation

@chusitoo
Copy link
Copy Markdown
Contributor

@chusitoo chusitoo commented Dec 26, 2023

Implemented as described in open-telemetry/opentelemetry-cpp#2047:

  • Appender implemented in log4cxx namespace as the macros that generate boilerplate code appear to depend on that invariant.
  • Minimal examples provided to demonstrate the setup required.
  • Basic unit testing.
  • Tried using the same flags as those used in otel-cpp for configuring cmake project.
  • Add clang format file to help keep the style in line with otel-cpp repo

@chusitoo chusitoo marked this pull request as ready for review December 26, 2023 20:57
@chusitoo chusitoo requested a review from a team December 26, 2023 20:57
Copy link
Copy Markdown
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instrumentation:log4cxx Log4cxx log appender

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants