Skip to content

[CI] Add CI for instrumentation/glog#425

Merged
marcalff merged 9 commits intoopen-telemetry:mainfrom
marcalff:fix_ci_glog
Apr 16, 2024
Merged

[CI] Add CI for instrumentation/glog#425
marcalff merged 9 commits intoopen-telemetry:mainfrom
marcalff:fix_ci_glog

Conversation

@marcalff
Copy link
Copy Markdown
Member

@marcalff marcalff commented Apr 6, 2024

Fixes #421

Fixed CMakeLists:

  • Require GTest 1.12.0. Building with 1.11 breaks the build due to a gtest bug.

Upgraded to google/glog 0.7.0

  • Fixed CMakeLists
  • Removed GLOG_VERSION_HAS_LOGMESSAGETIME
  • Fixed warnings related to timstamps.

@marcalff marcalff marked this pull request as ready for review April 6, 2024 22:17
@marcalff marcalff requested a review from a team April 6, 2024 22:17
@marcalff
Copy link
Copy Markdown
Member Author

marcalff commented Apr 7, 2024

@chusitoo FYI

@marcalff marcalff added the instrumentation:glog GLog log appender label Apr 13, 2024
@marcalff marcalff merged commit 6217b44 into open-telemetry:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instrumentation:glog GLog log appender

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Add CI for instrumentation/glog

3 participants